Add Device errors to bot-list status

appengine/swarming/ui/res/imp/botlist/bot-list.html

Index: appengine/swarming/ui/res/imp/botlist/bot-list.html
diff --git a/appengine/swarming/ui/res/imp/botlist/bot-list.html b/appengine/swarming/ui/res/imp/botlist/bot-list.html
index cbdfdb360eb7a7dc2fa4f4edbf0ca199ea62e7da..bcb5c57802acac538a703991a41c5e20653b2095 100644
--- a/appengine/swarming/ui/res/imp/botlist/bot-list.html
+++ b/appengine/swarming/ui/res/imp/botlist/bot-list.html
@@ -404,6 +404,20 @@
           if (msg === UNKNOWN || msg === "true" || msg === true) {
             msg = this._attribute(bot, "error");
           }
+          if (msg === "No available devices.") {

[stephana, 2017/03/21 17:33:39]

This seems very fragile. Is there no stricter way (via field that has a fixed
set of values) to determine whether we need to look at other fields. 

[kjlubick, 2017/03/21 19:56:15]

Removed the if statement, because I think it will always be useful to see the
device errors.

+            var errs = [];
+            // Show all the errors that are active to make it more clear if this
+            // is a transient error (e.g. device is too hot) or if it is requires
+            // human interaction (e.g. device is unauthorized)
+            this._devices(bot).forEach(function(d){
+              if (d.state !== "available") {
+                errs.push(d.state);
+              }
+            });
+            if (errs.length) {
+              msg += " ["+errs.join(",")+"]";
+            }
+          }
           return "Quarantined: " + msg;
         }
         return "Alive";