Fasta type inference prototype #2

Fasta type inference prototype #2

[scheglov, 2017-03-24 15:38:09]

scheglov@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2017-03-24 15:38:10]

https://codereview.chromium.org/2768533002/diff/60001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/builder/shadow_ast.dart (right):

https://codereview.chromium.org/2768533002/diff/60001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/builder/shadow_ast.dart:95: throw new
UnimplementedError('$context');
If I understand correctly, "context" will be Iterable<String> here.

main() {
  foo(['aaa', 'bbb']);
}
foo(Iterable<String> p) {}

[Paul Berry, 2017-03-24 17:59:50]

https://codereview.chromium.org/2768533002/diff/60001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/builder/shadow_ast.dart (right):

https://codereview.chromium.org/2768533002/diff/60001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/builder/shadow_ast.dart:95: throw new
UnimplementedError('$context');
On 2017/03/24 15:38:10, scheglov wrote:
> If I understand correctly, "context" will be Iterable<String> here.
> 
> main() {
>   foo(['aaa', 'bbb']);
> }
> foo(Iterable<String> p) {}

You are correct.  This entire method is a hack that I put in place just to get
some simple cases prototyped, and I don't intend to ever land this code.  The
right way to do this is to do something like StaticTypeAnalyzer.inferListType
(pkg/analyzer/lib/src/generated/static_type_analyzer.dart), which sets up the
proper preconditions and then calls inferGenericFunctionOrType, which handles
the "Iterable" case as part of its general-purpose algorithm.