Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 27685004: Fix support for Visual Studio 2010 Express projects. (Closed)

Created:
7 years, 2 months ago by Jamie Madill
Modified:
7 years, 2 months ago
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Fix support for Visual Studio 2010 Express projects. Use the proper version string, and omit the folder mappings section for 2010 Express. Patch by jmadill@chromium.org! BUG=376 R=scottmg@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1767

Patch Set 1 #

Total comments: 1

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M pylib/gyp/MSVSNew.py View 1 chunk +9 lines, -8 lines 0 comments Download
M pylib/gyp/MSVSVersion.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Jamie Madill
Please take a look!
7 years, 2 months ago (2013-10-21 18:13:46 UTC) #1
scottmg
https://codereview.chromium.org/27685004/diff/1/pylib/gyp/MSVSVersion.py File pylib/gyp/MSVSVersion.py (right): https://codereview.chromium.org/27685004/diff/1/pylib/gyp/MSVSVersion.py#newcode252 pylib/gyp/MSVSVersion.py:252: 'Visual C++ Express 2010', This changes what's in the ...
7 years, 2 months ago (2013-10-21 20:42:28 UTC) #2
Jamie Madill
On 2013/10/21 20:42:28, scottmg wrote: > Any idea if we should change 2012e and 2013e? ...
7 years, 2 months ago (2013-10-22 14:32:41 UTC) #3
scottmg
OK, thanks for checking. lgtm. I can land it for you.
7 years, 2 months ago (2013-10-22 16:32:11 UTC) #4
Jamie Madill
On 2013/10/22 16:32:11, scottmg wrote: > OK, thanks for checking. lgtm. > > I can ...
7 years, 2 months ago (2013-10-22 16:46:45 UTC) #5
scottmg
7 years, 2 months ago (2013-10-22 19:30:04 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r1767.

Powered by Google App Engine
This is Rietveld 408576698