Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/cookie_table/CookiesTable.js

Issue 2768383003: DevTools: Fixes regression in cookies tab in Network panel having no output (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Apple Inc. All rights reserved. 2 * Copyright (C) 2009 Apple Inc. All rights reserved.
3 * Copyright (C) 2009 Joseph Pecoraro 3 * Copyright (C) 2009 Joseph Pecoraro
4 * Copyright (C) 2010 Google Inc. All rights reserved. 4 * Copyright (C) 2010 Google Inc. All rights reserved.
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 131 matching lines...) Expand 10 before | Expand all | Expand 10 after
142 142
143 /** 143 /**
144 * @override 144 * @override
145 */ 145 */
146 willHide() { 146 willHide() {
147 this._lastEditedColumnId = null; 147 this._lastEditedColumnId = null;
148 } 148 }
149 149
150 /** 150 /**
151 * @param {{current: ?SDK.Cookie, neighbor: ?SDK.Cookie}} selectionCookies 151 * @param {{current: ?SDK.Cookie, neighbor: ?SDK.Cookie}} selectionCookies
152 * @param {!Array<!SDK.Cookie>} cookies 152 * @param {?Array<!SDK.Cookie>} cookies
153 * @return {?SDK.Cookie} 153 * @return {?SDK.Cookie}
154 */ 154 */
155 _findSelectedCookie(selectionCookies, cookies) { 155 _findSelectedCookie(selectionCookies, cookies) {
156 if (!cookies)
157 return null;
158
156 var current = selectionCookies.current; 159 var current = selectionCookies.current;
157 var foundCurrent = cookies.find(cookie => this._isSameCookie(cookie, current )); 160 var foundCurrent = cookies.find(cookie => this._isSameCookie(cookie, current ));
158 if (foundCurrent) 161 if (foundCurrent)
159 return foundCurrent; 162 return foundCurrent;
160 163
161 var neighbor = selectionCookies.neighbor; 164 var neighbor = selectionCookies.neighbor;
162 var foundNeighbor = cookies.find(cookie => this._isSameCookie(cookie, neighb or)); 165 var foundNeighbor = cookies.find(cookie => this._isSameCookie(cookie, neighb or));
163 if (foundNeighbor) 166 if (foundNeighbor)
164 return foundNeighbor; 167 return foundNeighbor;
165 168
(...skipping 298 matching lines...) Expand 10 before | Expand all | Expand 10 after
464 } 467 }
465 468
466 _refresh() { 469 _refresh() {
467 if (this._refreshCallback) 470 if (this._refreshCallback)
468 this._refreshCallback(); 471 this._refreshCallback();
469 } 472 }
470 }; 473 };
471 474
472 /** @const */ 475 /** @const */
473 CookieTable.CookiesTable._expiresSessionValue = Common.UIString('Session'); 476 CookieTable.CookiesTable._expiresSessionValue = Common.UIString('Session');
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698