Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3280)

Unified Diff: chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc

Issue 276833002: Make the App Info Dialog appear modal (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed comment Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc
diff --git a/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc b/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc
index ce79b3b21b83158a48b73f1be3f56463306b2fa9..7ae1f420379a32c7dcb59d57fc505be82fca87e4 100644
--- a/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc
+++ b/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc
@@ -9,6 +9,8 @@
#include "chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_tab.h"
#include "chrome/browser/ui/views/constrained_window_views.h"
#include "grit/generated_resources.h"
+#include "ui/app_list/app_list_switches.h"
tapted 2014/05/21 03:40:57 I don't think these includes are needed in the cur
sashab 2014/05/22 07:20:21 Yup, they were needed before this changed. Done.
+#include "ui/aura/window.h"
#include "ui/base/l10n/l10n_util.h"
#include "ui/views/controls/tabbed_pane/tabbed_pane.h"
#include "ui/views/layout/fill_layout.h"
@@ -17,12 +19,15 @@
#include "ui/views/window/dialog_delegate.h"
void ShowAppInfoDialog(gfx::NativeWindow parent_window,
+ gfx::Rect target_bounds,
Profile* profile,
const extensions::Extension* app,
const base::Closure& close_callback) {
- CreateBrowserModalDialogViews(
+ views::Widget* dialog = CreateBrowserModalDialogViews(
new AppInfoDialog(parent_window, profile, app, close_callback),
- parent_window)->Show();
+ parent_window);
+ dialog->SetBounds(target_bounds);
+ dialog->Show();
}
AppInfoDialog::AppInfoDialog(gfx::NativeWindow parent_window,

Powered by Google App Engine
This is Rietveld 408576698