Make the App Info Dialog appear modal

chrome/browser/ui/app_list/app_list_controller_delegate_views.cc

Index: chrome/browser/ui/app_list/app_list_controller_delegate_views.cc
diff --git a/chrome/browser/ui/app_list/app_list_controller_delegate_views.cc b/chrome/browser/ui/app_list/app_list_controller_delegate_views.cc
index 2ec4e9b7df47e7f6a001484f2d59b698a048bcdf..ce34abcdbe3f910acb98d6a00d17e031b6b58e4a 100644
--- a/chrome/browser/ui/app_list/app_list_controller_delegate_views.cc
+++ b/chrome/browser/ui/app_list/app_list_controller_delegate_views.cc
@@ -5,6 +5,7 @@
 #include "chrome/browser/ui/app_list/app_list_controller_delegate_views.h"
 
 #include "chrome/browser/ui/app_list/app_list_service_views.h"
+#include "ui/app_list/views/app_list_view.h"
 
 AppListControllerDelegateViews::AppListControllerDelegateViews(
     AppListServiceViews* service)
@@ -14,15 +15,28 @@ AppListControllerDelegateViews::AppListControllerDelegateViews(
 
 AppListControllerDelegateViews::~AppListControllerDelegateViews() {}
 
+gfx::Rect AppListControllerDelegateViews::GetAppListBounds() {
+  app_list::AppListView* app_list_view = service_->shower().app_list();

[tapted, 2014/05/21 03:40:57]

It feels a bit weird to use the view bounds instead of the window bounds. I
guess they're the same, but is there another reason?

And I see earlier patchsets have the bounds/insetting logic in
app_info_dialog_views.cc - I'm guessing they moved to support the landscape app
list, but you could probably achieve the same just by giving the bounds of the
info dialog a max-width, and using |parent_window->bounds()|

[sashab, 2014/05/22 07:20:21]

As discussed, this is needed on platforms where the app list's shadow affects
the size of the parent window. Added a comment to explain.

+  if (app_list_view)
+    return app_list_view->GetBoundsInScreen();
+  return gfx::Rect();
+}
+
 void AppListControllerDelegateViews::ViewClosing() {
   service_->OnViewBeingDestroyed();
 }
 
 void AppListControllerDelegateViews::OnShowExtensionPrompt() {
+  app_list::AppListView* app_list_view = service_->shower().app_list();
+  if (app_list_view)

[tapted, 2014/05/21 03:40:57]

I think it's impossible for this to be false. Perhaps

DCHECK(service_->shower().app_list());
service_->shower().app_list()->ShowAppListOverlay(true);

[sashab, 2014/05/22 07:20:21]

Done.

+    app_list_view->ShowAppListOverlay(true);
   service_->set_can_dismiss(false);
 }
 
 void AppListControllerDelegateViews::OnCloseExtensionPrompt() {
+  app_list::AppListView* app_list_view = service_->shower().app_list();
+  if (app_list_view)

[tapted, 2014/05/21 03:40:57]

This one... I'm guessing can actually be false if you close the entire app
launcher via the taskbar/shelf with the dialog open, but it should have a
comment about that here. (First you should check that my guess is correct,
otherwise a DCHECK is better)

[sashab, 2014/05/22 07:20:21]

Yup, you're right, this can never be the case - this code is actually never run
if the app list is closed separately, so a DCHECK is correct.

+    app_list_view->ShowAppListOverlay(false);
   service_->set_can_dismiss(true);
 }