chrome/browser/ui/app_list/app_list_controller_delegate_impl.cc - Issue 276833002: Make the App Info Dialog appear modal

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/app_list_controller_delegate_impl.cc

Issue 276833002: Make the App Info Dialog appear modal (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Added new browser test Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/app_list/app_list_controller_delegate_impl.cc

diff --git a/chrome/browser/ui/app_list/app_list_controller_delegate_impl.cc b/chrome/browser/ui/app_list/app_list_controller_delegate_impl.cc

index c6865e9b212c766b2efb6edc1d5905b71d6f0e8b..c14af7f0c7a918a823e08a8c5a90b8d983b07bbf 100644

--- a/chrome/browser/ui/app_list/app_list_controller_delegate_impl.cc

+++ b/chrome/browser/ui/app_list/app_list_controller_delegate_impl.cc

@@ -71,7 +71,7 @@ void AppListControllerDelegateImpl::DoCreateShortcutsFlow(

gfx::NativeWindow parent_window = GetAppListWindow();

if (!parent_window)

return;

- OnShowExtensionPrompt();

+ OnShowChildDialog();

chrome::ShowCreateChromeAppShortcutsDialog(

parent_window, profile, extension,

base::Bind(&AppListControllerDelegateImpl::OnCloseCreateShortcutsPrompt,

@@ -130,5 +130,5 @@ void AppListControllerDelegateImpl::FillLaunchParams(AppLaunchParams* params) {}

void AppListControllerDelegateImpl::OnCloseCreateShortcutsPrompt(

bool created) {

- OnCloseExtensionPrompt();

+ OnCloseChildDialog();

}