Make the App Info Dialog appear modal

chrome/browser/ui/app_list/app_list_controller_delegate.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_APP_LIST_APP_LIST_CONTROLLER_DELEGATE_H_
 #define CHROME_BROWSER_UI_APP_LIST_APP_LIST_CONTROLLER_DELEGATE_H_
 
 #include <string>
 
 #include "chrome/common/extensions/extension_constants.h"
 #include "ui/gfx/native_widget_types.h"
 
 class Profile;
 
 namespace base {
 class FilePath;
 }
 
 namespace extensions {
 class Extension;
 class ExtensionSet;
 class InstallTracker;
 }
 
 namespace gfx {
 class ImageSkia;
+class Rect;
 }
 
 // Interface to allow the view delegate to call out to whatever is controlling
 // the app list. This will have different implementations for different
 // platforms.
 class AppListControllerDelegate {
  public:
   // Indicates the source of an app list activation, for tracking purposes.
   enum AppListSource {
     LAUNCH_FROM_UNKNOWN,
@@ skipping 16 matching lines @@
 
   // Dismisses the view.
   virtual void DismissView() = 0;
 
   // Handle the view being closed.
   virtual void ViewClosing();
 
   // Get app list window.
   virtual gfx::NativeWindow GetAppListWindow() = 0;
 
+  // Get the content bounds of the app list in the screen. On platforms that
+  // use views, this returns the bounds of the AppListView. Without views, this
+  // returns a 0x0 rectangle.
+  virtual gfx::Rect GetAppListBounds() = 0;

[tapted, 2014/05/21 03:40:57]

I think it's fine to give an implementation in the base clase that returns
gfx::Rect(). This will avoid the duplication in AppListControllerDelegateImpl
and TestAppListControllerDelegate

[sashab, 2014/05/22 07:20:21]

Good thinking. Done.

+
   // Get the application icon to be used, if any, for the app list.
   virtual gfx::ImageSkia GetWindowIcon() = 0;
 
   // Control of pinning apps.
   virtual bool IsAppPinned(const std::string& extension_id) = 0;
   virtual void PinApp(const std::string& extension_id) = 0;
   virtual void UnpinApp(const std::string& extension_id) = 0;
   virtual Pinnable GetPinnable() = 0;
 
   // Be aware of the extension prompt (either uninstalling flow or enable flow).
   virtual void OnShowExtensionPrompt();

[tapted, 2014/05/21 03:40:57]

The comment here (at least) needs to be updated. But I think the function names
are now iffy too -- the info dialog isn't prompting the user for information, so
isn't a prompt.

Maybe

OnShowChildDialog();
OnCloseChildDialog();

[sashab, 2014/05/22 07:20:21]

Done.

   virtual void OnCloseExtensionPrompt();
 
   // Whether the controller supports a Create Shortcuts flow.
   virtual bool CanDoCreateShortcutsFlow() = 0;
 
   // Show the dialog to create shortcuts. Call only if
   // CanDoCreateShortcutsFlow() returns true.
   virtual void DoCreateShortcutsFlow(Profile* profile,
                                      const std::string& extension_id) = 0;
 
@@ skipping 67 matching lines @@
   extensions::InstallTracker* GetInstallTrackerFor(Profile* profile);
 
   // Get the list of installed apps for the given profile.
   void GetApps(Profile* profile, extensions::ExtensionSet* out_apps);
 
   // Called when a search is started using the app list search box.
   void OnSearchStarted();
 };
 
 #endif  // CHROME_BROWSER_UI_APP_LIST_APP_LIST_CONTROLLER_DELEGATE_H_