Make the App Info Dialog appear modal

chrome/browser/ui/app_list/app_list_controller_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/app_list/app_list_controller_delegate.h"
 
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_util.h"
 #include "chrome/browser/extensions/install_tracker_factory.h"
 #include "chrome/browser/extensions/launch_util.h"
@@ skipping 81 matching lines @@
       extensions::ExtensionSystem::Get(profile)->extension_service();
   DCHECK(service);
   const extensions::Extension* extension = service->GetInstalledExtension(
       extension_id);
   DCHECK(extension);
 
   gfx::NativeWindow parent_window = GetAppListWindow();
   if (!parent_window)
     return;
 
+  // The dialog is inset so the app list is still visible around the edges.
+  unsigned int kAppListDialogHorizontalBorderInsets = 10;

[tapted, 2014/05/21 03:40:57]

nit: just `int` is fine - shouldn't use unsigned integers (see "On Unsigned
Integers" at
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Integer_Types)

[sashab, 2014/05/22 07:20:21]

Done.

+  unsigned int kAppListDialogVerticalBorderInsets = 10;
+
+  // If we are using the experimental app list, inset the dialog further so it
+  // appears as a vertical column in the center of the app list.
+  if (app_list::switches::IsExperimentalAppListEnabled()) {

[tapted, 2014/05/21 03:40:57]

this should check IsCenteredAppListEnabled() instead I think

[sashab, 2014/05/22 07:20:21]

Yes, you're right! Good find! Done :)

+    kAppListDialogHorizontalBorderInsets += 100;

[tapted, 2014/05/21 03:40:57]

Hm - I would make them both actually const. e.g.

  // For the centred app list, inset the dialog..
  const int kAppListDialogHorizontalBorderInsets =
      app_list::switches::IsCenteredAppListEnabled() ? 10 : 110;
  const int kAppListDialogVerticalBorderInsets = 10;

[sashab, 2014/05/22 07:20:21]

Done.

+  }
+
+  gfx::Rect dialog_bounds = GetAppListBounds();
+  dialog_bounds.Inset(kAppListDialogHorizontalBorderInsets,
+                      kAppListDialogVerticalBorderInsets);
+
   OnShowExtensionPrompt();
   ShowAppInfoDialog(
       parent_window,
+      dialog_bounds,
       profile,
       extension,
       base::Bind(&AppListControllerDelegate::OnCloseExtensionPrompt,
                  base::Unretained(this)));
 }
 
 void AppListControllerDelegate::UninstallApp(Profile* profile,
                                              const std::string& app_id) {
   // ExtensionUninstall deletes itself when done or aborted.
   ExtensionUninstaller* uninstaller =
@@ skipping 91 matching lines @@
   out_apps->InsertAll(registry->enabled_extensions());
   out_apps->InsertAll(registry->disabled_extensions());
   out_apps->InsertAll(registry->terminated_extensions());
 }
 
 void AppListControllerDelegate::OnSearchStarted() {
 #if defined(ENABLE_RLZ)
   RLZTracker::RecordAppListSearch();
 #endif
 }