Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1464)

Unified Diff: content/browser/pointer_lock_browsertest.cc

Issue 2768263005: Fix PointerLockBrowserTest on Mac. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/pointer_lock_browsertest_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/pointer_lock_browsertest.cc
diff --git a/content/browser/pointer_lock_browsertest.cc b/content/browser/pointer_lock_browsertest.cc
index cf1a792e15947c44088869410ffc52421fed8944..46fde73b719a92cd480fac0f78ab92d58b611237 100644
--- a/content/browser/pointer_lock_browsertest.cc
+++ b/content/browser/pointer_lock_browsertest.cc
@@ -272,17 +272,9 @@ IN_PROC_BROWSER_TEST_F(PointerLockBrowserTest, PointerLockEventRouting) {
EXPECT_EQ(17, movementY);
}
-// Flaky on Mac. See comment on https://codereview.chromium.org/2760343002.
-#if defined(OS_MACOSX)
-#define MAYBE_PointerLockChildFrameDetached \
- DISABLED_PointerLockChildFrameDetached
-#else
-#define MAYBE_PointerLockChildFrameDetached PointerLockChildFrameDetached
-#endif
// Tests that the browser will not unlock the pointer if a RenderWidgetHostView
// that doesn't hold the pointer lock is destroyed.
-IN_PROC_BROWSER_TEST_F(PointerLockBrowserTest,
- MAYBE_PointerLockChildFrameDetached) {
+IN_PROC_BROWSER_TEST_F(PointerLockBrowserTest, PointerLockChildFrameDetached) {
GURL main_url(embedded_test_server()->GetURL(
"a.com", "/cross_site_iframe_factory.html?a(b)"));
EXPECT_TRUE(NavigateToURL(shell(), main_url));
« no previous file with comments | « no previous file | content/browser/pointer_lock_browsertest_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698