Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Unified Diff: components/ukm/ukm_service.h

Issue 2768263003: Plugins: Add UKM Metrics to Flash loads (Closed)
Patch Set: merge Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/plugins/plugin_info_message_filter.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/ukm/ukm_service.h
diff --git a/components/ukm/ukm_service.h b/components/ukm/ukm_service.h
index 1a03c95947a3f12e12efebf391bda38b9c7c82ae..7247e4d4d80d1fa0b69078450c246f4b68884872 100644
--- a/components/ukm/ukm_service.h
+++ b/components/ukm/ukm_service.h
@@ -20,6 +20,7 @@
#include "components/ukm/ukm_reporting_service.h"
#include "url/gurl.h"
+class PluginInfoMessageFilter;
class PrefRegistrySimple;
class PrefService;
class UkmPageLoadMetricsObserver;
@@ -44,7 +45,7 @@ extern const base::Feature kUkmFeature;
// The URL-Keyed Metrics (UKM) service is responsible for gathering and
// uploading reports that contain fine grained performance metrics including
// URLs for top-level navigations.
-class UkmService : public base::SupportsWeakPtr<UkmService> {
+class UkmService {
public:
// Constructs a UkmService.
// Calling code is responsible for ensuring that the lifetime of
@@ -108,8 +109,9 @@ class UkmService : public base::SupportsWeakPtr<UkmService> {
}
private:
- friend UkmPageLoadMetricsObserver;
friend autofill::AutofillMetrics;
+ friend PluginInfoMessageFilter;
+ friend UkmPageLoadMetricsObserver;
FRIEND_TEST_ALL_PREFIXES(UkmServiceTest, AddEntryOnlyWithNonEmptyMetrics);
FRIEND_TEST_ALL_PREFIXES(UkmServiceTest, EntryBuilderAndSerialization);
FRIEND_TEST_ALL_PREFIXES(UkmServiceTest,
« no previous file with comments | « chrome/browser/plugins/plugin_info_message_filter.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698