Plugins: Add UKM Metrics to Flash loads

components/ukm/ukm_service.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_UKM_UKM_SERVICE_H_
 #define COMPONENTS_UKM_UKM_SERVICE_H_
 
 #include <stddef.h>
 #include <memory>
 #include <vector>
 
 #include "base/callback.h"
 #include "base/feature_list.h"
 #include "base/macros.h"
 #include "base/memory/weak_ptr.h"
 #include "base/threading/thread_checker.h"
 #include "build/build_config.h"
 #include "components/metrics/metrics_provider.h"
 #include "components/metrics/metrics_reporting_scheduler.h"
 #include "components/metrics/persisted_logs.h"
 #include "url/gurl.h"
 
+class PluginInfoMessageFilter;
 class PrefRegistrySimple;
 class PrefService;
 class UkmPageLoadMetricsObserver;
 
 namespace autofill {
 class AutofillMetrics;
 }  // namespace autofill
 
 namespace metrics {
 class MetricsLogUploader;
 class MetricsServiceClient;
 }
 
 namespace ukm {
 
 class UkmEntry;
 class UkmEntryBuilder;
 class UkmSource;
 
 // This feature controls whether UkmService should be created.
 extern const base::Feature kUkmFeature;
 
 // The URL-Keyed Metrics (UKM) service is responsible for gathering and
 // uploading reports that contain fine grained performance metrics including
 // URLs for top-level navigations.
 class UkmService : public base::SupportsWeakPtr<UkmService> {

[Bernhard Bauer, 2017/03/27 11:04:43]

Yak-shaving: Is this actually used? For internal callbacks there is already a
WeakPtrFactory.

[tommycli, 2017/03/28 17:20:49]

Done.

  public:
   // Constructs a UkmService.
   // Calling code is responsible for ensuring that the lifetime of
   // |pref_service| is longer than the lifetime of UkmService.
   UkmService(PrefService* pref_service, metrics::MetricsServiceClient* client);
   virtual ~UkmService();
 
   // Get the new source ID, which is unique for the duration of a browser
   // session.
   static int32_t GetNewSourceID();
@@ skipping 43 matching lines @@
   const std::map<int32_t, std::unique_ptr<UkmSource>>& sources_for_testing()
       const {
     return sources_;
   }
 
   const std::vector<std::unique_ptr<UkmEntry>>& entries_for_testing() const {
     return entries_;
   }
 
  private:
+  friend autofill::AutofillMetrics;
+  friend PluginInfoMessageFilter;
   friend UkmPageLoadMetricsObserver;
-  friend autofill::AutofillMetrics;
   FRIEND_TEST_ALL_PREFIXES(UkmServiceTest, AddEntryOnlyWithNonEmptyMetrics);
   FRIEND_TEST_ALL_PREFIXES(UkmServiceTest, EntryBuilderAndSerialization);
   FRIEND_TEST_ALL_PREFIXES(UkmServiceTest,
                            LogsUploadedOnlyWhenHavingSourcesOrEntries);
   FRIEND_TEST_ALL_PREFIXES(UkmServiceTest, MetricsProviderTest);
   FRIEND_TEST_ALL_PREFIXES(UkmServiceTest, PersistAndPurge);
   FRIEND_TEST_ALL_PREFIXES(UkmServiceTest, WhitelistEntryTest);
 
   // Get a new UkmEntryBuilder object for the specified source ID and event,
   // which can get metrics added to.
@@ skipping 75 matching lines @@
   // Weak pointers factory used to post task on different threads. All weak
   // pointers managed by this factory have the same lifetime as UkmService.
   base::WeakPtrFactory<UkmService> self_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(UkmService);
 };
 
 }  // namespace ukm
 
 #endif  // COMPONENTS_UKM_UKM_SERVICE_H_