[MD settings] update content settings when incognito changes

chrome/browser/resources/settings/site_settings/site_list.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * Enumeration mapping all possible controlled-by values for exceptions to
  * icons.
  * @enum {string}
  */
 var iconControlledBy = {
@@ skipping 85 matching lines @@
     showBlockAction_: Boolean,
 
     /**
      * Whether to show the 'Clear on exit' action in the action
      * menu.
      * @private
      */
     showSessionOnlyAction_: Boolean,
 
     /**
-     * Keeps track of the incognito status of the current profile (whether one
-     * exists).
-     * @private
-     */
-    incognitoProfileActive_: {
-      type: Boolean,
-      value: false,
-    },
-
-    /**
      * All possible actions in the action menu.
      * @private
      */
     actions_: {
       readOnly: true,
       type: Object,
       values: {
         ALLOW: 'Allow',
         BLOCK: 'Block',
         RESET: 'Reset',
@@ skipping 17 matching lines @@
    * Called when a site changes permission.
    * @param {string} category The category of the site that changed.
    * @param {string} site The site that changed.
    * @private
    */
   siteWithinCategoryChanged_: function(category, site) {
     if (category == this.category || this.allSites)
       this.configureWidget_();
   },
 
-  onIncognitoStatusChanged_: function(incognitoEnabled) {
-    // A change notification is not sent for each site that is deleted during
-    // incognito profile destruction. Therefore, we reconfigure the list when
-    // the incognito profile is destroyed, except for SESSION_ONLY, which won't
-    // have any incognito exceptions.
+  /**
+   * Called for each site list when incognito is enabled or disabled. Only
+   * called on change (opening N incogito windows only fires one message).
+   * Another message is sent when the *last* incognito window closes.
+   * @private
+   */
+  onIncognitoStatusChanged_: function() {
+    // The SESSION_ONLY list won't have any incognito exceptions. (Minor
+    // optimization, not required).
     if (this.categorySubtype == settings.PermissionValues.SESSION_ONLY)
       return;
 
-    if (this.incognitoProfileActive_)
-      this.configureWidget_();  // The incognito profile is being destroyed.
-
-    this.incognitoProfileActive_ = incognitoEnabled;
+    // A change notification is not sent for each site. So we repopulate the
+    // whole list when the incognito profile is created or destroyed.
+    this.populateList_();
   },
 
   /**
    * Configures the action menu, visibility of the widget and shows the list.
    * @private
    */
   configureWidget_: function() {
     // The observer for All Sites fires before the attached/ready event, so
     // initialize this here.
     if (this.browserProxy_ === undefined) {
@@ skipping 329 matching lines @@
 
   /** @private */
   closeActionMenu_: function() {
     this.actionMenuSite_ = null;
     var actionMenu = /** @type {!CrActionMenuElement} */ (
         this.$$('dialog[is=cr-action-menu]'));
     if (actionMenu.open)
       actionMenu.close();
   },
 });