Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: milo/appengine/buildbucket/properties.go

Issue 2768203002: Milo: Fix Gerrit CL reporting in buildbucket view (Closed)
Patch Set: Review Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « milo/appengine/buildbucket/common.go ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: milo/appengine/buildbucket/properties.go
diff --git a/milo/appengine/buildbucket/properties.go b/milo/appengine/buildbucket/properties.go
index 34e5f85489f326be37de754fa517b5443f4a1b29..904c2a4c7a126ac99876dd9211c933a7f1e04259 100644
--- a/milo/appengine/buildbucket/properties.go
+++ b/milo/appengine/buildbucket/properties.go
@@ -18,13 +18,13 @@ type properties struct {
RietveldURL string `json:"rietveld"` // e.g. "https://codereview.chromium.org"
Issue number `json:"issue"` // e.g. 2127373005
- PatchSet number `json:"patchset"` // e.g. 40001
+ PatchSet number `json:"patchset"` // e.g. 40001 for rietveld
- GerritURL string `json:"gerrit"` // e.g. "https://chromium-review.googlesource.com"
- GerritChangeNumber int `json:"event.change.number"` // e.g. 358171
- GerritChangeID string `json:"event.change.id"` // e.g. "infra%2Finfra~master~Iee05b76799d577d491f533b8acaa4560ac14a806"
- GerritChangeURL string `json:"event.change.url"` // e.g. "https://chromium-review.googlesource.com/#/c/358171"
- GerritPatchRef string `json:"event.patchSet.ref"` // e.g. "refs/changes/71/358171/2"
+ GerritPatchURL string `json:"patch_gerrit_url"` // e.g. "https://chromium-review.googlesource.com"
+ GerritPatchIssue int `json:"patch_issue"` // e.g. 358171
+ GerritPatchSet number `json:"patch_set"` // e.g. 1
+ GerritPatchProject string `json:"patch_project"` // e.g. "infra/infra"
+ GerritPatchRepositoryURL string `json:"patch_repository_url"` // e.g. https://chromium.googlesource.com/infra/infra
Revision string `json:"revision"` // e.g. "0b04861933367c62630751702c84fd64bc3caf6f"
BlameList []string `json:"blamelist"` // e.g. ["someone@chromium.org"]
« no previous file with comments | « milo/appengine/buildbucket/common.go ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698