Milo: Fix Gerrit CL reporting in buildbucket view

milo/appengine/buildbucket/properties.go

 // Copyright 2016 The LUCI Authors. All rights reserved.
 // Use of this source code is governed under the Apache License, Version 2.0
 // that can be found in the LICENSE file.
 
 package buildbucket
 
 import (
         "bytes"
         "strconv"
 )
 
 // This file is about buildbucket build params in the format supported by
 // Buildbot.
 
 // properties is well-established build properties.
 type properties struct {
         PatchStorage string `json:"patch_storage"` // e.g. "rietveld", "gerrit"
 
         RietveldURL string `json:"rietveld"` // e.g. "https://codereview.chromium.org"
         Issue       number `json:"issue"`    // e.g. 2127373005
-        PatchSet    number `json:"patchset"` // e.g. 40001
+        PatchSet    number `json:"patchset"` // e.g. 40001 for rietveld or 1 for gerrit

[nodir, 2017/03/24 06:35:02]

apparently for Gerrit it is "patch_set" with underscore.

We could have Patch_Set, but I find it ugly. Why not take advantage of json
field mapping and rename fields so that their names clearly indicate what they
describe rather than they are mapped to? I propose the code review-related
fields to have "Rietveld" and "Gerrit" prefixes. i.e. fields RietveldURL,
RietveldIssue, RietveldPatchset, GerritURL, GerritChange (i am not sure why the
property is called issue. issue is a rietveld term. Changes in Gerrit are called
"changes", hence /c/ in path), GerritPatchSet, GerritProject,
GerritRepositoryURL.

After writing this comment I realized that they had "Gerrit" prefix :)

 
-        GerritURL          string `json:"gerrit"`              // e.g. "https://chromium-review.googlesource.com"
-        GerritChangeNumber int    `json:"event.change.number"` // e.g. 358171
-        GerritChangeID     string `json:"event.change.id"`     // e.g. "infra%2Finfra~master~Iee05b76799d577d491f533b8acaa4560ac14a806"
-        GerritChangeURL    string `json:"event.change.url"`    // e.g. "https://chromium-review.googlesource.com/#/c/358171"
-        GerritPatchRef     string `json:"event.patchSet.ref"`  // e.g. "refs/changes/71/358171/2"
+        PatchGerritURL     string `json:"patch_gerrit_url"`     // e.g. "https://chromium-review.googlesource.com"
+        PatchIssue         int    `json:"patch_issue"`          // e.g. 358171
+        PatchProject       string `json:"patch_project"`        // e.g. "infra/infra"
+        PatchRepositoryURL string `json:"patch_repository_url"` // e.g. https://chromium.googlesource.com/infra/infra
 
         Revision  string   `json:"revision"`  // e.g. "0b04861933367c62630751702c84fd64bc3caf6f"
         BlameList []string `json:"blamelist"` // e.g. ["someone@chromium.org"]
 
         // Fields below are present only in ResultDetails.
 
         GotRevision string `json:"got_revision"` // e.g. "0b04861933367c62630751702c84fd64bc3caf6f"
         BuildNumber int    `json:"buildnumber"`  // e.g. 3021
 }
 
@@ skipping 25 matching lines @@
         BuilderName string `json:"builder_name"`
         Properties  properties
         Changes     []change
 }
 
 // resultDetails is contents of "result_details_json" buildbucket build field
 // in the format supported by Buildbot.
 type resultDetails struct {
         Properties properties
 }