Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Issue 2768153002: When generating CodeSourceMaps, reassign function ids once per function instead of once per inlinin… (Closed)

Created:
3 years, 9 months ago by rmacnak
Modified:
3 years, 9 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

When generating CodeSourceMaps, reassign function ids once per function instead of once per inlining site. R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/a52db232d68ef262c3b6c5c5dce18dd79e311a70

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -17 lines) Patch
M runtime/vm/code_descriptors.h View 3 chunks +5 lines, -1 line 0 comments Download
M runtime/vm/code_descriptors.cc View 2 chunks +16 lines, -8 lines 0 comments Download
M runtime/vm/raw_object.h View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
dart2js product x64 before VMIsolate(CodeSize): 180142 Isolate(CodeSize): 4160775 ReadOnlyData(CodeSize): 5283920 Instructions(CodeSize): 20055840 Total(CodeSize): 29680677 after ...
3 years, 9 months ago (2017-03-22 22:38:41 UTC) #2
Florian Schneider
lgtm
3 years, 9 months ago (2017-03-24 16:21:06 UTC) #3
rmacnak
3 years, 9 months ago (2017-03-24 21:41:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a52db232d68ef262c3b6c5c5dce18dd79e311a70 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698