Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4142)

Unified Diff: chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc

Issue 2768133002: [Web Payments] Refactor sheet display to allow updating view content (Closed)
Patch Set: Add comments. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc
diff --git a/chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc b/chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc
index 525b426ed240f0d9cc43b2917d4f0eb25edde8a4..b44d6b2c08c5c3950472be92de4e354b1fffd7f8 100644
--- a/chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc
+++ b/chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc
@@ -142,10 +142,6 @@ CreditCardEditorViewController::CreateHeaderView() {
return view;
}
-int CreditCardEditorViewController::GetViewHeaderTitleId() const {
- return IDS_PAYMENT_REQUEST_CREDIT_CARD_EDITOR_ADD_TITLE;
-}
-
std::vector<EditorField> CreditCardEditorViewController::GetFieldDefinitions() {
return std::vector<EditorField>{
{autofill::CREDIT_CARD_NUMBER,
@@ -232,6 +228,11 @@ CreditCardEditorViewController::GetComboboxModelForType(
return std::unique_ptr<ui::ComboboxModel>();
}
+base::string16 CreditCardEditorViewController::GetSheetTitle() {
+ return l10n_util::GetStringUTF16(
+ IDS_PAYMENT_REQUEST_CREDIT_CARD_EDITOR_ADD_TITLE);
+}
+
CreditCardEditorViewController::CreditCardValidationDelegate::
CreditCardValidationDelegate(
const EditorField& field,

Powered by Google App Engine
This is Rietveld 408576698