third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueDeserializer.cpp - Issue 2768113002: WIP: Create a LongStringCollection that transfers long strings with fewer copies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueDeserializer.cpp

Issue 2768113002: WIP: Create a LongStringCollection that transfers long strings with fewer copies.

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/serialization/LongStringCollection.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueDeserializer.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueDeserializer.cpp b/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueDeserializer.cpp

index 6fe6418850cd580284c5de016641fab4a8f8e50d..52907fac41c94ca77f4fcc6603667363f9539a8e 100644

--- a/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueDeserializer.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueDeserializer.cpp

@@ -170,6 +170,12 @@ void V8ScriptValueDeserializer::transfer() {

for (const auto& image : *imageBitmapContents)

m_transferredImageBitmaps.push_back(ImageBitmap::create(image));

}

+ // Transfer long string references.

+ const auto& longStrings =

+ m_serializedScriptValue->longStrings().getAll(isolate);

+ for (unsigned i = 0; i < longStrings.size(); i++)

+ m_deserializer.TransferLongString(i, longStrings[i]);

}

bool V8ScriptValueDeserializer::readUTF8String(String* string) {