Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Side by Side Diff: content/public/browser/voice_interaction_helper.h

Issue 2768093005: Send voice interaction structure from cros to Arc. (Closed)
Patch Set: address trybot error Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CONTENT_PUBLIC_BROWSER_VOICE_INTERACTION_HELPER_H_
6 #define CONTENT_PUBLIC_BROWSER_VOICE_INTERACTION_HELPER_H_
7
8 #include <stdint.h>
9
10 #include <memory>
11 #include <utility>
xiyuan 2017/04/03 19:01:08 nit: not used?
Muyuan 2017/04/03 20:25:35 Done.
12 #include <vector>
13
14 #include "base/callback.h"
15 #include "base/strings/string16.h"
16 #include "ui/gfx/geometry/rect.h"
17
18 namespace content {
19
20 class WebContents;
21
22 struct AXViewStructure {
23 gfx::Rect rect;
24 base::string16 text;
25 float text_size;
26 int32_t color;
27 int32_t bgcolor;
xiyuan 2017/04/03 19:01:08 nit: bgcolor -> bg_color
Muyuan 2017/04/03 20:25:35 same reason.. https://cs.chromium.org/chromium/sr
28 bool bold;
29 bool italic;
30 bool underline;
31 bool line_through;
32
33 bool has_selection;
34 int32_t start_selection;
35 int32_t end_selection;
36
37 std::string class_name;
38 std::vector<std::unique_ptr<AXViewStructure>> children;
39
40 AXViewStructure();
41 ~AXViewStructure();
42 DISALLOW_COPY_AND_ASSIGN(AXViewStructure);
43 };
44
45 void GetAXViewStructure(
46 WebContents* web_contents,
47 const base::Callback<void(const AXViewStructure*)>& callback);
xiyuan 2017/04/03 19:01:08 Change "const AXViewStructure*" to either a ref "c
Muyuan 2017/04/03 20:25:35 Done.
48
49 } // namespace android
50
51 #endif // CONTENT_PUBLIC_BROWSER_ANDROID_VOICE_INTERACTION_HELPER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698