Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: extensions/renderer/resources/messaging.js

Issue 2768093002: [Reland][Extensions Bindings] Add support for filtered events (Closed)
Patch Set: Fix Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/resources/messaging.js
diff --git a/extensions/renderer/resources/messaging.js b/extensions/renderer/resources/messaging.js
index 37bbf72a9aa32bf0abbc84586673b178983745e4..86c110b1de860cc661478dd05a7b64bea4081088 100644
--- a/extensions/renderer/resources/messaging.js
+++ b/extensions/renderer/resources/messaging.js
@@ -23,11 +23,17 @@
var kPortClosedError = 'Attempting to use a disconnected port object';
var jsEvent;
- function createAnonymousEvent(schema, options) {
+ function createAnonymousEvent(schema) {
if (bindingUtil) {
// Native custom events ignore schema.
- return bindingUtil.createCustomEvent(undefined, undefined, options);
+ var supportsFilters = false;
+ return bindingUtil.createCustomEvent(undefined, undefined,
+ supportsFilters);
}
+ var options = {
+ __proto__: null,
+ unmanaged: true,
+ };
if (!jsEvent)
jsEvent = require('event_bindings').Event;
return new jsEvent(undefined, schema, options);
@@ -61,12 +67,8 @@
type: 'any',
optional: true,
};
- var options = {
- __proto__: null,
- unmanaged: true,
- };
- this.onDisconnect = createAnonymousEvent([portSchema], options);
- this.onMessage = createAnonymousEvent([messageSchema, portSchema], options);
+ this.onDisconnect = createAnonymousEvent([portSchema]);
+ this.onMessage = createAnonymousEvent([messageSchema, portSchema]);
}
$Object.setPrototypeOf(PortImpl.prototype, null);
« no previous file with comments | « extensions/renderer/resources/guest_view/guest_view_events.js ('k') | extensions/renderer/worker_thread_dispatcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698