Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Unified Diff: extensions/renderer/api_bindings_system_unittest.cc

Issue 2768093002: [Reland][Extensions Bindings] Add support for filtered events (Closed)
Patch Set: Fix Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/api_bindings_system_unittest.h ('k') | extensions/renderer/api_event_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/api_bindings_system_unittest.cc
diff --git a/extensions/renderer/api_bindings_system_unittest.cc b/extensions/renderer/api_bindings_system_unittest.cc
index bac9580bf953a4fb0b1d1acd57d0466ac316b5b8..ac5729a2ff0d16c3427076f0e388e3f1386169c1 100644
--- a/extensions/renderer/api_bindings_system_unittest.cc
+++ b/extensions/renderer/api_bindings_system_unittest.cc
@@ -10,6 +10,7 @@
#include "base/stl_util.h"
#include "base/strings/stringprintf.h"
#include "base/values.h"
+#include "extensions/common/event_filtering_info.h"
#include "extensions/common/extension_api.h"
#include "extensions/renderer/api_binding.h"
#include "extensions/renderer/api_binding_hooks.h"
@@ -158,6 +159,7 @@ void APIBindingsSystemTest::OnAPIRequest(
void APIBindingsSystemTest::OnEventListenersChanged(
const std::string& event_name,
binding::EventListenersChanged changed,
+ const base::DictionaryValue* filter,
v8::Local<v8::Context> context) {}
void APIBindingsSystemTest::ValidateLastRequest(
@@ -267,7 +269,7 @@ TEST_F(APIBindingsSystemTest, TestInitializationAndCallbacks) {
std::unique_ptr<base::ListValue> expected_args =
ListValueFromString(kResponseArgsJson);
bindings_system()->FireEventInContext("alpha.alphaEvent", context,
- *expected_args);
+ *expected_args, EventFilteringInfo());
EXPECT_EQ(ReplaceSingleQuotes(kResponseArgsJson),
GetStringPropertyFromObject(context->Global(), context,
« no previous file with comments | « extensions/renderer/api_bindings_system_unittest.h ('k') | extensions/renderer/api_event_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698