[Reland][Extensions Bindings] Add support for filtered events

extensions/renderer/api_binding_js_util.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/renderer/api_binding_js_util.h"
 
 #include "base/values.h"
 #include "extensions/renderer/api_event_handler.h"
 #include "extensions/renderer/api_request_handler.h"
 #include "extensions/renderer/api_signature.h"
@@ skipping 57 matching lines @@
     v8::Local<v8::Function> massager) {
   v8::Isolate* isolate = arguments->isolate();
   v8::HandleScope handle_scope(isolate);
   v8::Local<v8::Object> holder;
   CHECK(arguments->GetHolder(&holder));
   v8::Local<v8::Context> context = holder->CreationContext();
 
   event_handler_->RegisterArgumentMassager(context, event_name, massager);
 }
 
-void APIBindingJSUtil::CreateCustomEvent(
-    gin::Arguments* arguments,
-    v8::Local<v8::Value> v8_event_name,
-    v8::Local<v8::Value> unused_schema,
-    v8::Local<v8::Value> unused_event_options) {
+void APIBindingJSUtil::CreateCustomEvent(gin::Arguments* arguments,
+                                         v8::Local<v8::Value> v8_event_name,
+                                         v8::Local<v8::Value> unused_schema,
+                                         bool supports_filters) {
   v8::Isolate* isolate = arguments->isolate();
   v8::HandleScope handle_scope(isolate);
   v8::Local<v8::Object> holder;
   CHECK(arguments->GetHolder(&holder));
   v8::Local<v8::Context> context = holder->CreationContext();
 
   std::string event_name;
   if (!v8_event_name->IsUndefined()) {
     if (!v8_event_name->IsString()) {
       NOTREACHED();
       return;
     }
     event_name = gin::V8ToString(v8_event_name);
   }
 
+  DCHECK(!supports_filters || !event_name.empty())
+      << "Events that support filters cannot be anonymous.";
+
   v8::Local<v8::Value> event;
-  if (event_name.empty())
+  if (event_name.empty()) {
     event = event_handler_->CreateAnonymousEventInstance(context);
-  else
-    event = event_handler_->CreateEventInstance(event_name, context);
+  } else {
+    event = event_handler_->CreateEventInstance(event_name, supports_filters,
+                                                context);
+  }
 
   arguments->Return(event);
 }
 
 void APIBindingJSUtil::InvalidateEvent(gin::Arguments* arguments,
                                        v8::Local<v8::Object> event) {
   v8::Isolate* isolate = arguments->isolate();
   v8::HandleScope handle_scope(isolate);
   v8::Local<v8::Object> holder;
   CHECK(arguments->GetHolder(&holder));
   v8::Local<v8::Context> context = holder->CreationContext();
   event_handler_->InvalidateCustomEvent(context, event);
 }
 
 }  // namespace extensions