Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Unified Diff: chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc

Issue 2768083004: Use OneShotTimer in AddToHomescreenDataFetcher (Closed)
Patch Set: Stop earlier Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
diff --git a/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc b/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
index a05a2037283710922947277e90a032e950490e79..18092bb1727fe100ef94bc84775d92740b4af2c7 100644
--- a/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
+++ b/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
@@ -81,7 +81,6 @@ AddToHomescreenDataFetcher::AddToHomescreenDataFetcher(
weak_observer_(observer),
shortcut_info_(GetShortcutUrl(web_contents->GetBrowserContext(),
web_contents->GetLastCommittedURL())),
- data_timeout_timer_(false, false),
ideal_icon_size_in_px_(ideal_icon_size_in_px),
minimum_icon_size_in_px_(minimum_icon_size_in_px),
ideal_splash_image_size_in_px_(ideal_splash_image_size_in_px),
@@ -201,6 +200,8 @@ void AddToHomescreenDataFetcher::OnDidPerformInstallableCheck(
const InstallableData& data) {
badge_icon_.reset();
+ data_timeout_timer_.Stop();
dominickn 2017/03/24 02:42:37 I would do this even before badge_icon_.reset(). A
F 2017/03/27 18:52:01 Done.
+
if (!web_contents() || !weak_observer_ || is_installable_check_complete_)
return;
« no previous file with comments | « chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698