[MD settings] change sites to private sites_

[MD settings] change sites to private sites_

This CL renames a public |sites| member to a private |sites_| member in
the content settings site list.

(code cleaning)
BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

[dschuyler, 2017-03-23 22:26:48]

Description was changed from

==========
[MD settings] change sites to private sites_

This CL renames a public |sites| member to a private |sites_| member in
the content settings site list.

(code cleaning)
BUG=None
==========

to

==========
[MD settings] change sites to private sites_

This CL renames a public |sites| member to a private |sites_| member in
the content settings site list.

(code cleaning)
BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2017-03-23 22:26:50]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 22:27:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2017-03-23 22:27:50]

dschuyler@chromium.org changed reviewers:
+ dpapad@chromium.org

[dschuyler, 2017-03-23 22:27:51]

Follow up for CL 2769863006

[commit-bot: I haz the power, 2017-03-23 22:30:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 22:31:00]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[dpapad, 2017-03-23 22:38:12]

https://codereview.chromium.org/2768053004/diff/1/chrome/test/data/webui/sett...
File chrome/test/data/webui/settings/site_list_tests.js (right):

https://codereview.chromium.org/2768053004/diff/1/chrome/test/data/webui/sett...
chrome/test/data/webui/settings/site_list_tests.js:495: assertEquals(0,
testElement.sites_.length);
As I see it, making |sites| private, should be accompanied by cleaning up this
test to not use it anymore. Instead it should query the DOM and make assertions
on the DOM's state, for the reasons already mentioned at
https://codereview.chromium.org/2769863006/diff/20001/chrome/test/data/webui/...,
which gives greater test coverage.

From that perspective, just changing sites_ to private but not updating this
test to not use it, is not as beneficial. WDYT?