chrome/browser/ui/webui/browsing_history_handler.cc - Issue 2768023002: Move remaining @CalledByNative methods out of ChromeApplication.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/browsing_history_handler.cc

Issue 2768023002: Move remaining @CalledByNative methods out of ChromeApplication. (Closed)

Patch Set: Use DISALLOW_IMPLICIT_CONSTRUCTORS instead of DISALLOW_COPY_AND_ASSIGN Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/browsing_history_handler.cc

diff --git a/chrome/browser/ui/webui/browsing_history_handler.cc b/chrome/browser/ui/webui/browsing_history_handler.cc

index 1bf02e117dee04782598c2934a969b5f3e6ce3e7..dfc96e8147413efc80da89b653391631b03e12b7 100644

--- a/chrome/browser/ui/webui/browsing_history_handler.cc

+++ b/chrome/browser/ui/webui/browsing_history_handler.cc

@@ -55,7 +55,7 @@

#endif

#if defined(OS_ANDROID)

-#include "chrome/browser/android/chrome_application.h"

+#include "chrome/browser/android/preferences/preferences_launcher.h"

#else

#include "chrome/common/chrome_features.h"

#endif

@@ -403,7 +403,7 @@ void BrowsingHistoryHandler::HandleRemoveVisits(const base::ListValue* args) {

void BrowsingHistoryHandler::HandleClearBrowsingData(

const base::ListValue* args) {

#if defined(OS_ANDROID)

- chrome::android::ChromeApplication::OpenClearBrowsingData(

+ chrome::android::PreferencesLauncher::OpenClearBrowsingData(

web_ui()->GetWebContents());

#else

// TODO(beng): This is an improper direct dependency on Browser. Route this