third_party/WebKit/Source/platform/feature_policy/FeaturePolicyTest.cpp - Issue 2767983003: Initial Implementation of Iframe Attribute for Feature Policy (Part 4)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/feature_policy/FeaturePolicyTest.cpp

Issue 2767983003: Initial Implementation of Iframe Attribute for Feature Policy (Part 4) (Closed)

Patch Set: Nit Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.cpp ('K') | « third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.cpp ('k') | third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/feature_policy/FeaturePolicyTest.cpp

diff --git a/third_party/WebKit/Source/platform/feature_policy/FeaturePolicyTest.cpp b/third_party/WebKit/Source/platform/feature_policy/FeaturePolicyTest.cpp

index ae8756b514b6584346bf7eedf90de0140587949b..7728c12fe0fe50286c357ccd628638e3716228c0 100644

--- a/third_party/WebKit/Source/platform/feature_policy/FeaturePolicyTest.cpp

+++ b/third_party/WebKit/Source/platform/feature_policy/FeaturePolicyTest.cpp

@@ -119,7 +119,8 @@ TEST_F(FeaturePolicyTest, PolicyParsedCorrectly) {

TEST_F(FeaturePolicyTest, ParseEmptyContainerPolicy) {

WebParsedFeaturePolicy containerPolicy =

getContainerPolicyFromAllowedFeatures(

- std::vector<WebFeaturePolicyFeature>({}), m_originA.get());

+ std::vector<WebFeaturePolicyFeature>({}), false, false,

+ m_originA.get());

EXPECT_EQ(0UL, containerPolicy.size());

}

@@ -129,7 +130,7 @@ TEST_F(FeaturePolicyTest, ParseContainerPolicy) {

std::vector<WebFeaturePolicyFeature>(

{WebFeaturePolicyFeature::Vibrate,

WebFeaturePolicyFeature::Payment}),

- m_originA.get());

+ false, false, m_originA.get());

EXPECT_EQ(2UL, containerPolicy.size());

EXPECT_EQ(WebFeaturePolicyFeature::Vibrate, containerPolicy[0].feature);

EXPECT_FALSE(containerPolicy[0].matchesAllOrigins);