Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Unified Diff: third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp

Issue 2767983003: Initial Implementation of Iframe Attribute for Feature Policy (Part 4) (Closed)
Patch Set: Codereview: nit + added more unit tests for container policy Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp b/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp
index 7b84b1baecd94359931908e21588336bd21bf0a7..b4edfc8324191ba73b0cd34952ade74e6d7162b6 100644
--- a/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp
@@ -209,7 +209,8 @@ void HTMLFrameOwnerElement::SetSandboxFlags(SandboxFlags flags) {
// Recalculate the container policy in case the allow-same-origin flag has
// changed.
container_policy_ = GetContainerPolicyFromAllowedFeatures(
- AllowedFeatures(), GetOriginForFeaturePolicy());
+ AllowedFeatures(), AllowFullscreen(), AllowPaymentRequest(),
+ GetOriginForFeaturePolicy());
// Don't notify about updates if ContentFrame() is null, for example when
// the subframe hasn't been created yet.
@@ -234,7 +235,8 @@ void HTMLFrameOwnerElement::DisposeFrameOrPluginSoon(
void HTMLFrameOwnerElement::UpdateContainerPolicy() {
container_policy_ = GetContainerPolicyFromAllowedFeatures(
- AllowedFeatures(), GetOriginForFeaturePolicy());
+ AllowedFeatures(), AllowFullscreen(), AllowPaymentRequest(),
+ GetOriginForFeaturePolicy());
// Don't notify about updates if ContentFrame() is null, for example when
// the subframe hasn't been created yet.
if (ContentFrame()) {

Powered by Google App Engine
This is Rietveld 408576698