Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 2767943002: Revert "Fix some strong mode issues in the core libraries." (Closed)

Created:
3 years, 9 months ago by floitsch
Modified:
3 years, 9 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Fix some strong mode issues in the core libraries." This reverts commit e5c091e048370a839919cb341fe68904b9e73207. Committed: https://github.com/dart-lang/sdk/commit/a382f7845c034f3b97bb8532ad7247fad53494e1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -25 lines) Patch
M CHANGELOG.md View 1 chunk +0 lines, -6 lines 0 comments Download
M sdk/lib/async/stream.dart View 1 chunk +2 lines, -1 line 0 comments Download
M sdk/lib/collection/queue.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/convert/ascii.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M sdk/lib/convert/base64.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M sdk/lib/convert/chunked_conversion.dart View 1 chunk +10 lines, -0 lines 0 comments Download
M sdk/lib/convert/converter.dart View 1 chunk +2 lines, -1 line 0 comments Download
M sdk/lib/convert/html_escape.dart View 1 chunk +2 lines, -1 line 0 comments Download
M sdk/lib/convert/json.dart View 3 chunks +6 lines, -3 lines 0 comments Download
M sdk/lib/convert/line_splitter.dart View 1 chunk +2 lines, -1 line 0 comments Download
M sdk/lib/convert/utf.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M sdk/lib/io/data_transformer.dart View 1 chunk +2 lines, -1 line 0 comments Download
M sdk/lib/io/file_impl.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/io/string_transformer.dart View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
floitsch
scheduled_test package still uses a deprecated class.
3 years, 9 months ago (2017-03-22 15:54:05 UTC) #2
floitsch
TBR.
3 years, 9 months ago (2017-03-22 15:54:12 UTC) #3
floitsch
Committed patchset #1 (id:1) manually as a382f7845c034f3b97bb8532ad7247fad53494e1 (presubmit successful).
3 years, 9 months ago (2017-03-22 15:55:14 UTC) #5
vsm
3 years, 9 months ago (2017-03-22 16:00:19 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698