[cc] Don't send missed BeginFrames with past deadline.

cc/scheduler/begin_frame_source_unittest.cc

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/scheduler/begin_frame_source.h"
 
 #include <stdint.h>
 
 #include "base/memory/ptr_util.h"
 #include "base/test/test_simple_task_runner.h"
@@ skipping 784 matching lines @@
 }
 
 // ExternalBeginFrameSource testing --------------------------------------------
 class MockExternalBeginFrameSourceClient
     : public ExternalBeginFrameSourceClient {
  public:
   MOCK_METHOD1(OnNeedsBeginFrames, void(bool));
   MOCK_METHOD1(OnDidFinishFrame, void(const BeginFrameAck&));
 };
 
+class ExternalBeginFrameSourceForTest : public ExternalBeginFrameSource {
+ public:
+  using ExternalBeginFrameSource::ExternalBeginFrameSource;
+  base::TimeTicks Now() const override { return now_; }
+
+  base::TimeTicks now_;
+};
+
 class ExternalBeginFrameSourceTest : public ::testing::Test {
  public:
   std::unique_ptr<MockExternalBeginFrameSourceClient> client_;
-  std::unique_ptr<ExternalBeginFrameSource> source_;
+  std::unique_ptr<ExternalBeginFrameSourceForTest> source_;
   std::unique_ptr<MockBeginFrameObserver> obs_;
 
   void SetUp() override {
     client_.reset(new MockExternalBeginFrameSourceClient);
-    source_.reset(new ExternalBeginFrameSource(client_.get()));
+    source_.reset(new ExternalBeginFrameSourceForTest(client_.get()));
     obs_.reset(new MockBeginFrameObserver);
   }
 
   void TearDown() override {
     client_.reset();
     obs_.reset();
   }
 };
 
 TEST_F(ExternalBeginFrameSourceTest, CallsOnDidFinishFrameWithoutObservers) {
@@ skipping 77 matching lines @@
 
   // Providing same args through a different ExternalBeginFrameSource also does
   // not notify observer.
   EXPECT_BEGIN_FRAME_SOURCE_PAUSED(*obs_, false);
   EXPECT_CALL((*client_), OnNeedsBeginFrames(true)).Times(1);
   ExternalBeginFrameSource source2(client_.get());
   source2.AddObserver(obs_.get());
   source2.OnBeginFrame(args);
 }
 
+TEST_F(ExternalBeginFrameSourceTest, AddObserverSendsMissedBeginFrame) {
+  BeginFrameArgs args = CreateBeginFrameArgsForTesting(
+      BEGINFRAME_FROM_HERE, 0, 2, base::TimeTicks::FromInternalValue(10000));
+  EXPECT_CALL((*client_), OnDidFinishFrame(BeginFrameAck(0, 2, 2, 0, false)))
+      .Times(1);
+  source_->OnBeginFrame(args);
+
+  args.type = BeginFrameArgs::MISSED;
+  EXPECT_CALL((*client_), OnNeedsBeginFrames(true)).Times(1);
+  EXPECT_BEGIN_FRAME_SOURCE_PAUSED(*obs_, false);
+  EXPECT_BEGIN_FRAME_ARGS_USED(*obs_, args);
+  source_->AddObserver(obs_.get());
+}
+
+TEST_F(ExternalBeginFrameSourceTest,
+       AddObserverDoesNotSendMissedBeginFrameAfterDeadline) {
+  BeginFrameArgs args = CreateBeginFrameArgsForTesting(
+      BEGINFRAME_FROM_HERE, 0, 2, base::TimeTicks::FromInternalValue(10000));
+  EXPECT_CALL((*client_), OnDidFinishFrame(BeginFrameAck(0, 2, 2, 0, false)))
+      .Times(1);
+  source_->OnBeginFrame(args);
+
+  source_->now_ = args.deadline;
+  args.type = BeginFrameArgs::MISSED;
+  EXPECT_CALL((*client_), OnNeedsBeginFrames(true)).Times(1);
+  EXPECT_BEGIN_FRAME_SOURCE_PAUSED(*obs_, false);
+  // Should not call OnBeginFrame for missed BeginFrame with past deadline.
+  EXPECT_CALL((*obs_), OnBeginFrame(::testing::_)).Times(0);
+  source_->AddObserver(obs_.get());
+}
+
 }  // namespace
 }  // namespace cc