chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc - Issue 2767923002: Always use an async TaskScheduler in TestBrowserThreadBundle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc

Issue 2767923002: Always use an async TaskScheduler in TestBrowserThreadBundle. (Closed)

Patch Set: fix-test-error Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/policy/device_status_collector_browsertest.cc ('k') | chrome/browser/ui/app_list/arc/arc_app_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc

diff --git a/chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc b/chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc

index 789a4fb4acb82dfea0937dda65f59c4eebf42ed2..03805bac54d74c67d1c3650d9586012aaabcf073 100644

--- a/chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc

+++ b/chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc

@@ -402,10 +402,7 @@ class CloudPrintProxyPolicyStartupTest : public base::MultiProcessTest,

};

CloudPrintProxyPolicyStartupTest::CloudPrintProxyPolicyStartupTest()

- : // TaskScheduler must run on its own thread because the main thread waits

- // for a task running in it.

- thread_bundle_(content::TestBrowserThreadBundle::REAL_IO_THREAD |

- content::TestBrowserThreadBundle::REAL_TASK_SCHEDULER) {

+ : thread_bundle_(content::TestBrowserThreadBundle::REAL_IO_THREAD) {

// Although is really a unit test which runs in the browser_tests binary, it

// doesn't get the unit setup which normally happens in the unit test binary.

ChromeUnitTestSuite::InitializeProviders();