chrome/browser/ui/webui/print_preview/extension_printer_handler_unittest.cc - Issue 2767923002: Always use an async TaskScheduler in TestBrowserThreadBundle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/print_preview/extension_printer_handler_unittest.cc

Issue 2767923002: Always use an async TaskScheduler in TestBrowserThreadBundle. (Closed)

Patch Set: fix-test-errors Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/policy/device_status_collector_browsertest.cc ('K') | « chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc ('k') | content/browser/loader/resource_dispatcher_host_unittest.cc » ('j') | content/browser/loader/resource_dispatcher_host_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/print_preview/extension_printer_handler_unittest.cc

diff --git a/chrome/browser/ui/webui/print_preview/extension_printer_handler_unittest.cc b/chrome/browser/ui/webui/print_preview/extension_printer_handler_unittest.cc

index 56c50d1046063bc7552c4432eeab990e0be5a77e..668f8d6d60e3712515621e509cbd2ee4c758ae10 100644

--- a/chrome/browser/ui/webui/print_preview/extension_printer_handler_unittest.cc

+++ b/chrome/browser/ui/webui/print_preview/extension_printer_handler_unittest.cc

@@ -27,6 +27,7 @@

#include "chrome/browser/printing/pwg_raster_converter.h"

#include "chrome/test/base/testing_profile.h"

#include "components/version_info/version_info.h"

+#include "content/public/test/test_utils.h"

#include "device/base/mock_device_client.h"

#include "device/usb/mock_usb_device.h"

#include "device/usb/mock_usb_service.h"

@@ -787,7 +788,7 @@ TEST_F(ExtensionPrinterHandlerTest, Print_Pwg) {

EXPECT_EQ(0u, call_count);

- base::RunLoop().RunUntilIdle();

+ content::RunAllBlockingPoolTasksUntilIdle();

FakePrinterProviderAPI* fake_api = GetPrinterProviderAPI();

ASSERT_TRUE(fake_api);

@@ -841,7 +842,7 @@ TEST_F(ExtensionPrinterHandlerTest, Print_Pwg_NonDefaultSettings) {

EXPECT_EQ(0u, call_count);

- base::RunLoop().RunUntilIdle();

+ content::RunAllBlockingPoolTasksUntilIdle();

FakePrinterProviderAPI* fake_api = GetPrinterProviderAPI();

ASSERT_TRUE(fake_api);

@@ -895,7 +896,7 @@ TEST_F(ExtensionPrinterHandlerTest, Print_Pwg_Reset) {

EXPECT_EQ(0u, call_count);

- base::RunLoop().RunUntilIdle();

+ content::RunAllBlockingPoolTasksUntilIdle();

FakePrinterProviderAPI* fake_api = GetPrinterProviderAPI();

ASSERT_TRUE(fake_api);