Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Unified Diff: chrome/browser/spellchecker/spellcheck_message_filter_platform_mac_browsertest.cc

Issue 2767893002: Remove ScopedVector from chrome/browser/. (Closed)
Patch Set: Address comments from zea@ Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/spellchecker/spellcheck_message_filter_platform_mac_browsertest.cc
diff --git a/chrome/browser/spellchecker/spellcheck_message_filter_platform_mac_browsertest.cc b/chrome/browser/spellchecker/spellcheck_message_filter_platform_mac_browsertest.cc
index 4045425adb34f343c185f2cfa58b3a3474debeb7..45e970c1cc581f52326cec714cf83639eea36dd5 100644
--- a/chrome/browser/spellchecker/spellcheck_message_filter_platform_mac_browsertest.cc
+++ b/chrome/browser/spellchecker/spellcheck_message_filter_platform_mac_browsertest.cc
@@ -4,10 +4,12 @@
#include "components/spellcheck/browser/spellcheck_message_filter_platform.h"
+#include <memory>
#include <tuple>
+#include <vector>
#include "base/command_line.h"
-#include "base/memory/scoped_vector.h"
+#include "base/memory/ptr_util.h"
#include "base/run_loop.h"
#include "base/single_thread_task_runner.h"
#include "base/stl_util.h"
@@ -26,12 +28,12 @@ class TestingSpellCheckMessageFilter : public SpellCheckMessageFilterPlatform {
: SpellCheckMessageFilterPlatform(0), quit_closure_(quit_closure) {}
bool Send(IPC::Message* message) override {
- sent_messages_.push_back(message);
+ sent_messages_.push_back(base::WrapUnique(message));
main_thread_task_runner_->PostTask(FROM_HERE, quit_closure_);
return true;
}
- ScopedVector<IPC::Message> sent_messages_;
+ std::vector<std::unique_ptr<IPC::Message>> sent_messages_;
const scoped_refptr<base::SingleThreadTaskRunner> main_thread_task_runner_ =
base::ThreadTaskRunnerHandle::Get();
const base::Closure quit_closure_;
@@ -58,7 +60,7 @@ IN_PROC_BROWSER_TEST_F(SpellCheckMessageFilterPlatformMacBrowserTest,
SpellCheckMsg_RespondTextCheck::Param params;
bool ok = SpellCheckMsg_RespondTextCheck::Read(
- target->sent_messages_[0], &params);
+ target->sent_messages_[0].get(), &params);
std::vector<SpellCheckResult> sent_results = std::get<2>(params);
EXPECT_TRUE(ok);

Powered by Google App Engine
This is Rietveld 408576698