Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: chrome/browser/site_details_browsertest.cc

Issue 2767893002: Remove ScopedVector from chrome/browser/. (Closed)
Patch Set: Address comments from zea@ Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/site_details_browsertest.cc
diff --git a/chrome/browser/site_details_browsertest.cc b/chrome/browser/site_details_browsertest.cc
index c5b1cf1f770dab0ec1290e0ba86e74a825e3e330..b5800a499edc0cb9770c65540470c4a88bbcc992 100644
--- a/chrome/browser/site_details_browsertest.cc
+++ b/chrome/browser/site_details_browsertest.cc
@@ -7,7 +7,9 @@
#include <stddef.h>
#include <stdint.h>
+#include <memory>
#include <utility>
+#include <vector>
#include "base/bind_helpers.h"
#include "base/files/file_path.h"
@@ -238,7 +240,7 @@ class SiteDetailsBrowserTest : public ExtensionBrowserTest {
const Extension* extension = LoadExtension(dir->UnpackedPath());
EXPECT_TRUE(extension);
- temp_dirs_.push_back(dir.release());
+ temp_dirs_.push_back(std::move(dir));
return extension;
}
@@ -282,7 +284,7 @@ class SiteDetailsBrowserTest : public ExtensionBrowserTest {
const Extension* extension = LoadExtension(dir->UnpackedPath());
EXPECT_TRUE(extension);
- temp_dirs_.push_back(dir.release());
+ temp_dirs_.push_back(std::move(dir));
}
const Extension* CreateHostedApp(const std::string& name,
@@ -304,7 +306,7 @@ class SiteDetailsBrowserTest : public ExtensionBrowserTest {
const Extension* extension = LoadExtension(dir->UnpackedPath());
EXPECT_TRUE(extension);
- temp_dirs_.push_back(dir.release());
+ temp_dirs_.push_back(std::move(dir));
return extension;
}
@@ -353,7 +355,7 @@ class SiteDetailsBrowserTest : public ExtensionBrowserTest {
}
private:
- ScopedVector<TestExtensionDir> temp_dirs_;
+ std::vector<std::unique_ptr<TestExtensionDir>> temp_dirs_;
DISALLOW_COPY_AND_ASSIGN(SiteDetailsBrowserTest);
};

Powered by Google App Engine
This is Rietveld 408576698