Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Unified Diff: chrome/browser/feedback/system_logs/about_system_logs_fetcher.cc

Issue 2767893002: Remove ScopedVector from chrome/browser/. (Closed)
Patch Set: Address comments from zea@ Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/feedback/system_logs/about_system_logs_fetcher.cc
diff --git a/chrome/browser/feedback/system_logs/about_system_logs_fetcher.cc b/chrome/browser/feedback/system_logs/about_system_logs_fetcher.cc
index c75874358c04cd275218e48addef9de7915f44e3..619dd3b5a17b4f709630051c77e4a35855243d75 100644
--- a/chrome/browser/feedback/system_logs/about_system_logs_fetcher.cc
+++ b/chrome/browser/feedback/system_logs/about_system_logs_fetcher.cc
@@ -6,6 +6,7 @@
#include "base/bind.h"
#include "base/bind_helpers.h"
+#include "base/memory/ptr_util.h"
#include "build/build_config.h"
#include "chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.h"
#include "chrome/browser/feedback/system_logs/log_sources/memory_details_log_source.h"
@@ -25,20 +26,20 @@ using content::BrowserThread;
namespace system_logs {
AboutSystemLogsFetcher::AboutSystemLogsFetcher() {
- data_sources_.push_back(new ChromeInternalLogSource());
- data_sources_.push_back(new MemoryDetailsLogSource());
+ data_sources_.push_back(base::MakeUnique<ChromeInternalLogSource>());
+ data_sources_.push_back(base::MakeUnique<MemoryDetailsLogSource>());
#if defined(OS_CHROMEOS)
- data_sources_.push_back(new CommandLineLogSource());
- data_sources_.push_back(new DBusLogSource());
- data_sources_.push_back(new DeviceEventLogSource());
- data_sources_.push_back(new LsbReleaseLogSource());
- data_sources_.push_back(new TouchLogSource());
+ data_sources_.push_back(base::MakeUnique<CommandLineLogSource>());
+ data_sources_.push_back(base::MakeUnique<DBusLogSource>());
+ data_sources_.push_back(base::MakeUnique<DeviceEventLogSource>());
+ data_sources_.push_back(base::MakeUnique<LsbReleaseLogSource>());
+ data_sources_.push_back(base::MakeUnique<TouchLogSource>());
// Debug Daemon data source - currently only this data source supports
// the scrub_data parameter.
const bool scrub_data = false;
- data_sources_.push_back(new DebugDaemonLogSource(scrub_data));
+ data_sources_.push_back(base::MakeUnique<DebugDaemonLogSource>(scrub_data));
#endif
num_pending_requests_ = data_sources_.size();

Powered by Google App Engine
This is Rietveld 408576698