third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp - Issue 2767823002: Media Remoting: Add interstitial elements to media element shadow dom.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp

Issue 2767823002: Media Remoting: Add interstitial elements to media element shadow dom. (Closed)

Patch Set: Addressed liberato's comments. Changed to use HTMLDivElement instead of HTMLInputElement. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/html/shadow/MediaRemotingInterstitial.h ('K') | « third_party/WebKit/Source/core/paint/ThemePainter.cpp ('k') | third_party/WebKit/Source/platform/ThemeTypes.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp

diff --git a/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp b/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp

index 1524d7590cf2cc49c53499c868c9c80d133c1571..9776b6d04b67339a5968cc8924123659de081f9b 100644

--- a/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp

+++ b/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp

@@ -534,7 +534,9 @@ void MediaControlsImpl::MakeTransparent() {

bool MediaControlsImpl::ShouldHideMediaControls(unsigned behavior_flags) const {

// Never hide for a media element without visual representation.

if (!MediaElement().IsHTMLVideoElement() || !MediaElement().HasVideo() ||

- MediaElement().IsPlayingRemotely()) {

+ MediaElement().IsPlayingRemotely() ||

+ toHTMLVideoElement(MediaElement()).GetMediaRemotingStatus() ==

+ HTMLVideoElement::MediaRemotingStatus::kStarted) {

return false;

}