Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: third_party/WebKit/Source/core/html/HTMLVideoElement.h

Issue 2767823002: Media Remoting: Add interstitial elements to media element shadow dom. (Closed)
Patch Set: Addressed liberato's comments. Changed to use HTMLDivElement instead of HTMLInputElement. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLVideoElement.h
diff --git a/third_party/WebKit/Source/core/html/HTMLVideoElement.h b/third_party/WebKit/Source/core/html/HTMLVideoElement.h
index bc7e7faea680dbf4a3e4d82c1843dac4ecfdaab3..408668065081185fcbfd14f78646b449d387c58b 100644
--- a/third_party/WebKit/Source/core/html/HTMLVideoElement.h
+++ b/third_party/WebKit/Source/core/html/HTMLVideoElement.h
@@ -43,6 +43,7 @@ namespace blink {
class ExceptionState;
class ImageBitmapOptions;
class MediaCustomControlsFullscreenDetector;
+class MediaRemotingInterstitial;
class CORE_EXPORT HTMLVideoElement final : public HTMLMediaElement,
public CanvasImageSource,
@@ -53,6 +54,8 @@ class CORE_EXPORT HTMLVideoElement final : public HTMLMediaElement,
static HTMLVideoElement* Create(Document&);
DECLARE_VIRTUAL_TRACE();
+ enum MediaRemotingStatus { kNotStarted, kStarted, kDisabled };
mlamouri (slow - plz ping) 2017/04/13 17:20:51 Can you make this an enum class?
xjz 2017/04/13 19:12:11 Done.
+
// Node override.
Node::InsertionNotificationRequest InsertedInto(ContainerNode*) override;
void RemovedFrom(ContainerNode*) override;
@@ -130,6 +133,11 @@ class CORE_EXPORT HTMLVideoElement final : public HTMLMediaElement,
bool IsPersistent() const;
+ MediaRemotingStatus GetMediaRemotingStatus() const {
miu 2017/04/13 01:32:10 style nit: Inline accessors should be in lowercase
mlamouri (slow - plz ping) 2017/04/13 17:20:51 Unfortunately, this isn't true in Blink even after
xjz 2017/04/13 19:12:11 Thanks for clarification.
xjz 2017/04/13 19:12:11 Kept it unchanged according to the Blink style.
+ return media_remoting_status_;
+ }
+ void DisableMediaRemoting();
+
private:
friend class MediaCustomControlsFullscreenDetectorTest;
friend class HTMLMediaElementEventListenersTest;
@@ -154,11 +162,17 @@ class CORE_EXPORT HTMLVideoElement final : public HTMLMediaElement,
void UpdateDisplayState() override;
void DidMoveToNewDocument(Document& old_document) override;
void SetDisplayMode(DisplayMode) override;
+ void MediaRemotingStarted() final;
+ void MediaRemotingStopped() final;
Member<HTMLImageLoader> image_loader_;
Member<MediaCustomControlsFullscreenDetector>
custom_controls_fullscreen_detector_;
+ MediaRemotingStatus media_remoting_status_;
+
+ Member<MediaRemotingInterstitial> remoting_interstitial_;
+
AtomicString default_poster_url_;
bool is_persistent_ = false;

Powered by Google App Engine
This is Rietveld 408576698