third_party/WebKit/Source/core/html/shadow/MediaControls.cpp - Issue 2767823002: Media Remoting: Add interstitial elements to media element shadow dom.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/shadow/MediaControls.cpp

Issue 2767823002: Media Remoting: Add interstitial elements to media element shadow dom. (Closed)

Patch Set: Addressed mlamouri's comments. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/shadow/MediaControls.cpp

diff --git a/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp b/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp

index 811996a545f6752fcf5a449b696119c926d17b1c..64bb142b0c314171b1d74a0cc858f2fe9e9a70ae 100644

--- a/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp

+++ b/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp

@@ -518,7 +518,9 @@ void MediaControls::makeTransparent() {

bool MediaControls::shouldHideMediaControls(unsigned behaviorFlags) const {

// Never hide for a media element without visual representation.

if (!mediaElement().isHTMLVideoElement() || !mediaElement().hasVideo() ||

- mediaElement().isPlayingRemotely()) {

+ mediaElement().isPlayingRemotely() ||

+ toHTMLVideoElement(mediaElement()).mediaRemotingStatus() ==

+ HTMLVideoElement::MediaRemotingStatus::Started) {

return false;

}