Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: third_party/WebKit/Source/core/html/shadow/MediaRemotingElements.h

Issue 2767823002: Media Remoting: Add interstitial elements to media element shadow dom. (Closed)
Patch Set: Addressed liberato's comments. Changed to use HTMLDivElement instead of HTMLInputElement. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef MediaRemotingElements_h
6 #define MediaRemotingElements_h
7
8 #include "core/html/shadow/MediaRemotingInterstitial.h"
9
10 namespace blink {
11
12 class Text;
13
14 // ----------------------------
mlamouri (slow - plz ping) 2017/04/13 17:20:51 style: remove this here and below, add a quick doc
xjz 2017/04/13 19:12:12 Done.
15
16 class MediaRemotingDisableButtonElement final : public HTMLDivElement {
miu 2017/04/13 01:32:10 Nice. Yes, I think the DIV elements will be much l
xjz 2017/04/13 19:12:12 Thanks for the suggestion. :)
17 public:
18 explicit MediaRemotingDisableButtonElement(MediaRemotingInterstitial&);
mlamouri (slow - plz ping) 2017/04/13 17:20:51 I think this should be renamed. The name no longer
xjz 2017/04/13 19:12:12 Done. Renamed it to MediaRemotingExitButtonElement
19
20 void OnShown();
21 void OnHidden();
22 HTMLVideoElement& VideoElement() const;
mlamouri (slow - plz ping) 2017/04/13 17:20:51 nit: GetVideoElement()?
xjz 2017/04/13 19:12:12 Done.
23
24 DECLARE_VIRTUAL_TRACE();
25
26 private:
27 class MouseEventsListener;
28
29 Member<MediaRemotingInterstitial> interstitial_;
30 Member<MouseEventsListener> listener_;
31 Member<Text> text_;
32 };
33
34 // ----------------------------
35
36 class MediaRemotingCastMessageElement final : public HTMLDivElement {
37 public:
38 explicit MediaRemotingCastMessageElement(MediaRemotingInterstitial&);
39
40 DECLARE_VIRTUAL_TRACE();
41
42 private:
43 Member<Text> text_;
44 };
45
46 // ----------------------------
47
48 class MediaRemotingCastIconElement final : public HTMLDivElement {
49 public:
50 explicit MediaRemotingCastIconElement(MediaRemotingInterstitial&);
51 };
52
53 } // namespace blink
54
55 #endif // MediaRemotingElements_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698