Media Remoting: Add interstitial elements to media element shadow dom.

third_party/WebKit/Source/core/html/HTMLMediaElement.h

 /*
  * Copyright (C) 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights
  * reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 86 matching lines @@
   static bool isHLSURL(const KURL&);
 
   // If HTMLMediaElement is using MediaTracks (either placeholder or provided
   // by the page).
   static bool mediaTracksEnabledInternally();
 
   // Notify the HTMLMediaElement that the media controls settings have changed
   // for the given document.
   static void onMediaControlsEnabledChange(Document*);
 
+  // Assert the correct order of the children in shadow dom when DCHECK is on.
+  static void assertShadowRootChildren(ShadowRoot&);

[mlamouri (slow - plz ping), 2017/04/07 13:18:32]

Could this be `protected`?

[xjz, 2017/04/07 23:07:01]

Done. Moved it to 'protected'.

+
   DECLARE_VIRTUAL_TRACE();
 
   DECLARE_VIRTUAL_TRACE_WRAPPERS();
 
   void clearWeakMembers(Visitor*);
   WebMediaPlayer* webMediaPlayer() const { return m_webMediaPlayer.get(); }
 
   // Returns true if the loaded media has a video track.
   // Note that even an audio element can have video track in cases such as
   // <audio src="video.webm">, in which case this function will return true.
   bool hasVideo() const;
   // Returns true if loaded media has an audio track.
   bool hasAudio() const;
 
   bool supportsSave() const;
 
   WebLayer* platformLayer() const;
 
   enum DelayedActionType {
     LoadMediaResource = 1 << 0,
     LoadTextTrackResource = 1 << 1
   };
   void scheduleTextTrackResourceLoad();
 
   bool hasRemoteRoutes() const;
   bool isPlayingRemotely() const { return m_playingRemotely; }
+  virtual bool isMediaRemotingStarted() const { return false; }

[mlamouri (slow - plz ping), 2017/04/07 13:18:32]

Instead of making this a virtual on HTMLMediaElement, given that you use it in
only one place that checks for mediaElement.isHTMLVideoElement(), could you
simply do: `toHTMLVideoElement(mediaElement)->isMediaRemotingStarted()`?

[xjz, 2017/04/07 23:07:01]

Done.

 
   // error state
   MediaError* error() const;
 
   // network state
   void setSrc(const AtomicString&);
   const KURL& currentSrc() const { return m_currentSrc; }
   void setSrcObject(MediaStreamDescriptor*);
   MediaStreamDescriptor* getSrcObject() const { return m_srcObject.get(); }
 
@@ skipping 410 matching lines @@
   void rejectScheduledPlayPromises();
   void rejectPlayPromises(ExceptionCode, const String&);
   void rejectPlayPromisesInternal(ExceptionCode, const String&);
 
   EnumerationHistogram& showControlsHistogram() const;
 
   void onVisibilityChangedForAutoplay(bool isVisible);
 
   void viewportFillDebouncerTimerFired(TimerBase*);
 
+  virtual bool isMediaRemotingDisabled() const { return false; }
+
   TaskRunnerTimer<HTMLMediaElement> m_loadTimer;
   TaskRunnerTimer<HTMLMediaElement> m_progressEventTimer;
   TaskRunnerTimer<HTMLMediaElement> m_playbackProgressTimer;
   TaskRunnerTimer<HTMLMediaElement> m_audioTracksTimer;
   TaskRunnerTimer<HTMLMediaElement> m_viewportFillDebouncerTimer;
   TaskRunnerTimer<HTMLMediaElement> m_checkViewportIntersectionTimer;
 
   Member<TimeRanges> m_playedTimeRanges;
   Member<GenericEventQueue> m_asyncEventQueue;
 
@@ skipping 190 matching lines @@
 
 inline bool isHTMLMediaElement(const HTMLElement& element) {
   return isHTMLAudioElement(element) || isHTMLVideoElement(element);
 }
 
 DEFINE_HTMLELEMENT_TYPE_CASTS_WITH_FUNCTION(HTMLMediaElement);
 
 }  // namespace blink
 
 #endif  // HTMLMediaElement_h