Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyle.h

Issue 2767783003: Incorporate ComputedStyle::hasTransform when diffing transform styles. (Closed)
Patch Set: Sync to head. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/style/ComputedStyle.h
diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.h b/third_party/WebKit/Source/core/style/ComputedStyle.h
index 7ec9c51f4b883e324eb9c95b7648f71c4b11c2e2..d523524f2f4a70f126d11db987903fa7db7779ff 100644
--- a/third_party/WebKit/Source/core/style/ComputedStyle.h
+++ b/third_party/WebKit/Source/core/style/ComputedStyle.h
@@ -3283,6 +3283,11 @@ class CORE_EXPORT ComputedStyle : public ComputedStyleBase,
ETransformStyle3D usedTransformStyle3D() const {
return hasGroupingProperty() ? TransformStyle3DFlat : transformStyle3D();
}
+ // Returns whether the transform operations for |otherStyle| differ from the
+ // operations for this style instance. Note that callers may want to also
+ // check hasTransform(), as it is possible for two styles to have matching
+ // transform operations but differ in other transform-impacting style
+ // respects.
bool transformDataEquivalent(const ComputedStyle& otherStyle) const {
return m_rareNonInheritedData->m_transform ==
otherStyle.m_rareNonInheritedData->m_transform;
@@ -3696,6 +3701,10 @@ class CORE_EXPORT ComputedStyle : public ComputedStyleBase,
StyleInheritedVariables& mutableInheritedVariables();
StyleNonInheritedVariables& mutableNonInheritedVariables();
+
+ FRIEND_TEST_ALL_PREFIXES(
+ ComputedStyleTest,
+ UpdatePropertySpecificDifferencesRespectsTransformAnimation);
};
// FIXME: Reduce/remove the dependency on zoom adjusted int values.
« no previous file with comments | « third_party/WebKit/Source/core/paint/PaintLayerTest.cpp ('k') | third_party/WebKit/Source/core/style/ComputedStyle.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698