Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyle.cpp

Issue 2767783003: Incorporate ComputedStyle::hasTransform when diffing transform styles. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« third_party/WebKit/Source/core/paint/PaintLayer.cpp ('K') | « third_party/WebKit/Source/core/style/ComputedStyle.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/style/ComputedStyle.cpp
diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.cpp b/third_party/WebKit/Source/core/style/ComputedStyle.cpp
index 5dd19f8a4ccbf6b31a18c234b14f22b4c6f70557..e4e84761d9d1121f3e57783b0d3022624e38d778 100644
--- a/third_party/WebKit/Source/core/style/ComputedStyle.cpp
+++ b/third_party/WebKit/Source/core/style/ComputedStyle.cpp
@@ -1027,7 +1027,8 @@ void ComputedStyle::updatePropertySpecificDifferences(
diff.setZIndexChanged();
if (m_rareNonInheritedData.get() != other.m_rareNonInheritedData.get()) {
- if (!transformDataEquivalent(other) ||
+ if (hasTransform() != other.hasTransform() ||
chrishtr 2017/03/22 00:05:42 Add a comment here too.
wkorman 2017/03/22 01:28:02 Done.
+ !transformDataEquivalent(other) ||
m_rareNonInheritedData->m_perspective !=
other.m_rareNonInheritedData->m_perspective ||
m_rareNonInheritedData->m_perspectiveOrigin !=
« third_party/WebKit/Source/core/paint/PaintLayer.cpp ('K') | « third_party/WebKit/Source/core/style/ComputedStyle.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698