Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: pkg/kernel/test/closures/suite.dart

Issue 2767773004: Add Vector type to Kernel (Closed)
Patch Set: Add a note to return Run step in Closure Conversion test suite Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/kernel/test/closures/suite.dart
diff --git a/pkg/kernel/test/closures/suite.dart b/pkg/kernel/test/closures/suite.dart
index dc8acd757d4cf9ea29d30dbe02a629056fb0b5a7..3fbd3c21683adf9763cbf744ebea6b395017b1b0 100644
--- a/pkg/kernel/test/closures/suite.dart
+++ b/pkg/kernel/test/closures/suite.dart
@@ -64,7 +64,8 @@ class TestContext extends ChainContext {
updateExpectations: updateExpectations),
const WriteDill(),
const ReadDill(),
- const Run(),
+ // TODO(dmitryas): uncomment this when Vectors are added to VM.
karlklose 2017/03/22 14:34:19 Maybe file a bug and reference its number in the T
Dmitry Stefantsov 2017/03/23 11:22:43 Good idea! Done.
+ //const Run(),
];
Future<DartLoader> createLoader() async {
@@ -124,7 +125,9 @@ Future<TestContext> createContext(
Uri packages = Uri.base.resolve(".packages");
bool strongMode = false;
- bool updateExpectations = environment["updateExpectations"] == "true";
+ bool updateExpectations = const String.fromEnvironment("updateExpectations",
+ defaultValue: "false") ==
+ "true";
return new TestContext(sdk, vm, packages, strongMode,
createDartSdk(sdk, strongMode: strongMode), updateExpectations);
}

Powered by Google App Engine
This is Rietveld 408576698