Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: pkg/kernel/lib/type_propagation/builder.dart

Issue 2767773004: Add Vector type to Kernel (Closed)
Patch Set: Reformat comment with Markdown, throw exception in type propagation Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/kernel/lib/type_checker.dart ('k') | pkg/kernel/lib/visitor.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/kernel/lib/type_propagation/builder.dart
diff --git a/pkg/kernel/lib/type_propagation/builder.dart b/pkg/kernel/lib/type_propagation/builder.dart
index 2ac6e19b631d99390054b4991984e70bdd17572b..a7b4c9612e0ce26ab3be8e5bc96d285be748b6b2 100644
--- a/pkg/kernel/lib/type_propagation/builder.dart
+++ b/pkg/kernel/lib/type_propagation/builder.dart
@@ -1802,6 +1802,11 @@ class CovariantExternalTypeVisitor extends DartTypeVisitor<int> {
return builder.nullNode;
}
+ int visitVectorType(VectorType node) {
+ throw "Internal error: CovariantExternalTypeVisitor encountered VectorType "
+ "in native method signature";
+ }
+
int visitInterfaceType(InterfaceType node) {
int object = builder.getExternalInstanceVariable(node.classNode);
for (int i = 0; i < node.typeArguments.length; ++i) {
@@ -1909,6 +1914,8 @@ class ContravariantExternalTypeVisitor extends DartTypeVisitor<Null> {
visitVoidType(VoidType node) {}
+ visitVectorType(VectorType node) {}
+
visitInterfaceType(InterfaceType node) {
int escapePoint = builder.getInterfaceEscapeVariable(node.classNode);
environment.addAssign(input, escapePoint);
« no previous file with comments | « pkg/kernel/lib/type_checker.dart ('k') | pkg/kernel/lib/visitor.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698