Add Vector type to Kernel

pkg/kernel/lib/type_checker.dart

Index: pkg/kernel/lib/type_checker.dart
diff --git a/pkg/kernel/lib/type_checker.dart b/pkg/kernel/lib/type_checker.dart
index c6a89373d2e416b251279de6171918c7582f95e8..0b5436438e79fd29ec0f7b4a6ddaf2bdbac3f80a 100644
--- a/pkg/kernel/lib/type_checker.dart
+++ b/pkg/kernel/lib/type_checker.dart
@@ -690,6 +690,26 @@ class TypeCheckingVisitor
   }
 
   @override
+  DartType visitVectorGet(VectorGet node) {
+    return const DynamicType();

[asgerf, 2017/03/23 11:53:51]

Visit the "vector" subexpression to ensure it is type checked.

We could also check that the "vector" subexpression has static type VectorType.
(Otherwise why have the VectorType?)

[Dmitry Stefantsov, 2017/03/27 10:57:08]

Done.

+  }
+
+  @override
+  visitVectorSet(VectorSet node) {
+    return node.value.getStaticType(environment);

[asgerf, 2017/03/23 11:53:51]

We should not use getStaticType from the type checker as it does not recursively
type check all subexpressions, it only does what is necessary to compute the
type of that one expression.

The correct form would be:
  visitExpression(node.vector);
  return visitExpression(node.value);

As above, we could also check that the vector has type VectorType.

[Dmitry Stefantsov, 2017/03/27 10:57:09]

Done.

+  }
+
+  @override
+  visitVectorCopy(VectorCopy node) {
+    return node.getStaticType(environment);

[asgerf, 2017/03/23 11:53:51]

Same as above.

[Dmitry Stefantsov, 2017/03/27 10:57:08]

Done.

+  }
+
+  @override
+  DartType visitVectorCreation(VectorCreation node) {
+    return node.getStaticType(environment);

[asgerf, 2017/03/23 11:53:51]

Even though there are no subexpressions here, please refrain from calling
getStaticType altogether and just return const VectorType().

[Dmitry Stefantsov, 2017/03/27 10:57:08]

Done.

+  }
+
+  @override
   visitAssertStatement(AssertStatement node) {
     visitExpression(node.condition);
     if (node.message != null) {