Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1237)

Unified Diff: content/browser/frame_host/render_frame_host_manager_browsertest.cc

Issue 2767733002: Revert of Mark 3 tests flaky on android (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/security_exploit_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/render_frame_host_manager_browsertest.cc
diff --git a/content/browser/frame_host/render_frame_host_manager_browsertest.cc b/content/browser/frame_host/render_frame_host_manager_browsertest.cc
index 8d9da95e1faa76133ef59ed824cdd588166407ae..9f6afe7d49c3d3c06e49058371152ddd905970e6 100644
--- a/content/browser/frame_host/render_frame_host_manager_browsertest.cc
+++ b/content/browser/frame_host/render_frame_host_manager_browsertest.cc
@@ -1343,21 +1343,12 @@
EXPECT_FALSE(contents->GetController().GetVisibleEntry());
}
-#if defined(OS_ANDROID)
-// Flaky on android: https://crbug.com/703657
-#define MAYBE_DontShowLoadingURLIfNotInitialNav \
- DISABLED_DontShowLoadingURLIfNotInitialNav
-#else
-#define MAYBE_DontShowLoadingURLIfNotInitialNav \
- DontShowLoadingURLIfNotInitialNav
-#endif
-
// Test for crbug.com/9682. We should not show the URL for a pending renderer-
// initiated navigation in a new tab if it is not the initial navigation. In
// this case, the renderer will not notify us of a modification, so we cannot
// show the pending URL without allowing a spoof.
IN_PROC_BROWSER_TEST_F(RenderFrameHostManagerTest,
- MAYBE_DontShowLoadingURLIfNotInitialNav) {
+ DontShowLoadingURLIfNotInitialNav) {
ASSERT_TRUE(embedded_test_server()->Start());
// Load a page that can open a URL that won't commit in a new window.
« no previous file with comments | « no previous file | content/browser/security_exploit_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698