Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 2767723002: [sql] Disable a clang intrinsic in SQLite 3.17.0. (Closed)

Created:
3 years, 9 months ago by stevenjb
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3047
Project:
chromium
Visibility:
Public.

Description

[sql] Disable a clang intrinsic in SQLite 3.17.0. SQLite implements sqlite3MulInt64() using __builtin_mul_overflow() for appropriate versions of GCC or clang. But clang appears to provide this function in a non-standard library which our Android clang does not provide. It fails with an undefined symbol __mulodi4. [It is possible that this is specific to Chromium's packaged clang, but https://bugs.llvm.org//show_bug.cgi?id=28629 ] BUG=701524, 701518 Review-Url: https://codereview.chromium.org/2762233003 Cr-Commit-Position: refs/heads/master@{#458457} (cherry picked from commit 9e39ce92107b239f0043d55eef91e155b1471382)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -21 lines) Patch
M third_party/sqlite/amalgamation/sqlite3.c View 1 chunk +4 lines, -5 lines 0 comments Download
M third_party/sqlite/patches/0010-build-Undefined-symbol-in-intrinsic-on-clang.patch View 1 chunk +11 lines, -11 lines 0 comments Download
M third_party/sqlite/src/src/util.c View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
stevenjb
This failed to land :( Closing and re-attempting.
3 years, 9 months ago (2017-03-21 19:55:04 UTC) #1
stevenjb
3 years, 9 months ago (2017-03-21 19:57:12 UTC) #2
Message was sent while issue was closed.
On 2017/03/21 19:55:04, stevenjb wrote:
> This failed to land :( Closing and re-attempting.

Ah, it landed eventually, just slow, nevermind.

Powered by Google App Engine
This is Rietveld 408576698