Expose resources in Robolectric/JUnit tests.

chrome/android/junit/src/org/chromium/chrome/browser/suggestions/TileGroupTest.java

Index: chrome/android/junit/src/org/chromium/chrome/browser/suggestions/TileGroupTest.java
diff --git a/chrome/android/junit/src/org/chromium/chrome/browser/suggestions/TileGroupTest.java b/chrome/android/junit/src/org/chromium/chrome/browser/suggestions/TileGroupTest.java
index 0d365de1c43f2b1ff61604f5e29b74ca48eea575..4114c2ca5aec8b9f7341ae554b923065a7f0438c 100644
--- a/chrome/android/junit/src/org/chromium/chrome/browser/suggestions/TileGroupTest.java
+++ b/chrome/android/junit/src/org/chromium/chrome/browser/suggestions/TileGroupTest.java
@@ -20,11 +20,8 @@ import static org.mockito.Mockito.verifyNoMoreInteractions;
 import static org.mockito.Mockito.when;
 
 import android.content.Context;
-import android.content.res.Resources;
 import android.graphics.Bitmap;
 import android.graphics.Color;
-import android.support.annotation.ColorRes;
-import android.support.annotation.DimenRes;
 import android.support.annotation.LayoutRes;
 import android.view.LayoutInflater;
 import android.view.View;
@@ -45,7 +42,6 @@ import org.robolectric.RuntimeEnvironment;
 import org.robolectric.annotation.Config;
 import org.robolectric.annotation.Implementation;
 import org.robolectric.annotation.Implements;
-import org.robolectric.shadows.ShadowResources;
 
 import org.chromium.base.Callback;
 import org.chromium.chrome.R;
@@ -61,9 +57,7 @@ import org.chromium.testing.local.LocalRobolectricTestRunner;
  * Unit tests for {@link TileGroup}.
  */
 @RunWith(LocalRobolectricTestRunner.class)
-@Config(manifest = Config.NONE, sdk = 21,
-        shadows = {TileGroupTest.TileShadowResources.class,
-                TileGroupTest.ShadowLayoutInflater.class})
+@Config(manifest = Config.NONE, sdk = 21, shadows = {TileGroupTest.ShadowLayoutInflater.class})
 @Features(@Features.Register(ChromeFeatureList.NTP_OFFLINE_PAGES_FEATURE_NAME))
 public class TileGroupTest {
     private static final int MAX_TILES_TO_FETCH = 4;
@@ -413,28 +407,6 @@ public class TileGroupTest {
         public void destroy() {}
     }
 
-    /**
-     * Replacement for the {@link Resources} to allow loading resources used by {@link TileGroup} in
-     * unit tests.
-     * TODO(https://crbug.com/693573): Needed until unit tests can pick up resources themselves.
-     */
-    @Implements(Resources.class)
-    public static class TileShadowResources extends ShadowResources {
-        @Implementation
-        public int getDimensionPixelSize(@DimenRes int id) {
-            if (id == R.dimen.tile_view_icon_size) return 48;
-
-            throw new IllegalArgumentException();
-        }
-
-        @Implementation
-        public int getColor(@ColorRes int id) {
-            if (id == R.color.default_favicon_background_color) return Color.BLACK;
-
-            throw new IllegalArgumentException();
-        }
-    }
-
     /** Intercepts calls to inflate views to replace them with mocks. */
     @Implements(LayoutInflater.class)
     public static class ShadowLayoutInflater {

[dgn, 2017/03/21 18:16:41]

does it work when this one is removed too? AFAICT it's there for the same reason
as the shadow above.

[mikecase (-- gone --), 2017/03/21 18:39:36]

I get an error when I remove this....


Caused by: java.lang.RuntimeException: huh?
ResName{org.chromium.chrome:string/accessibility_ntp_offline_badge}
	at
org.robolectric.shadows.ShadowAssetManager.convertAndFill(ShadowAssetManager.java:157)
	at
org.robolectric.shadows.ShadowAssetManager.buildTypedValue(ShadowAssetManager.java:771)
	at
org.robolectric.shadows.ShadowAssetManager.attrsToTypedArray(ShadowAssetManager.java:797)
	at
org.robolectric.shadows.ShadowResources$ShadowTheme.obtainStyledAttributes(ShadowResources.java:221)
	at android.content.res.Resources$Theme.obtainStyledAttributes(Resources.java)
	at android.content.Context.obtainStyledAttributes(Context.java:472)
	at android.view.View.__constructor__(View.java:3677)
	at android.view.View.<init>(View.java)
	at android.widget.ImageView.<init>(ImageView.java)
	at android.support.v7.widget.AppCompatImageView.<init>(AppCompatImageView.java)
	at
org.chromium.chrome.browser.widget.TintedImageView.<init>(TintedImageView.java:28)
	at android.view.LayoutInflater.createView(LayoutInflater.java:607)
	at android.view.LayoutInflater.createViewFromTag(LayoutInflater.java:743)
	at android.view.LayoutInflater.rInflate(LayoutInflater.java:806)
	at android.view.LayoutInflater.inflate(LayoutInflater.java:504)
	at android.view.LayoutInflater.inflate(LayoutInflater.java:414)
	at
org.chromium.chrome.browser.suggestions.TileGroup.buildTileView(TileGroup.java:325)
	at
org.chromium.chrome.browser.suggestions.TileGroupTest.testIconLoadingWhenTileNotRegistered(TileGroupTest.java:342)


https://github.com/robolectric/robolectric/blob/055f4112eae8a2b865278f3e73e52...

Apparently, Robolectric is surprised to get a string resource here?

[dgn, 2017/03/22 10:23:47]

That's a string used a content description for accessibility purposes, and
defined here:
https://cs.chromium.org/chromium/src/chrome/android/java/strings/android_chro...

According to the source and the stack above, the resource was registered (it
could resolve the resource name from the id), but it failed getting the value.
String themselves seem fine as in the case where a resource value is found there
is some string specific processing.

So... any idea why getting the value from the resource table would fail?