Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2712)

Unified Diff: chrome/android/BUILD.gn

Issue 2767613002: Expose resources in Robolectric/JUnit tests. (Closed)
Patch Set: Rough draft for using build_config to find resources. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/BUILD.gn
diff --git a/chrome/android/BUILD.gn b/chrome/android/BUILD.gn
index 67f70c1eb1489bd2bf078811f8cd65d5d000b9cd..766771967130d0d2c8e37858975931e33c69847a 100644
--- a/chrome/android/BUILD.gn
+++ b/chrome/android/BUILD.gn
@@ -373,6 +373,17 @@ junit_binary("chrome_junit_tests") {
google_play_services_library,
]
srcjar_deps = [ "//base:base_build_config_gen" ]
+
+ package_name = manifest_package
+ # resource_dirs = [
+ # "//chrome/android/java/res/",
+ # "//chrome/android/java/res_chromium/",
+ # "$root_gen_dir/chrome/android/chrome_strings_grd_grit_output/",
+ # ]
+ resource_deps = [
+ ":chrome_java_resources",
+ ":chrome_strings_grd",
+ ]
mikecase (-- gone --) 2017/04/10 23:50:36 How does this look? You now dont have to specify t
agrieve 2017/04/11 00:25:02 Looks like you've gotten rid of this all together
}
chrome_version_java_dir = "$root_gen_dir/templates/chrome_version_java"
« no previous file with comments | « build/config/android/rules.gni ('k') | chrome/android/junit/src/org/chromium/chrome/browser/suggestions/TileGroupTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698