Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3395)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/android/lint/suppressions.xml

Issue 2767613002: Expose resources in Robolectric/JUnit tests. (Closed)
Patch Set: Rough draft for using build_config to find resources. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/gyp/create_test_runner_script.py ('k') | build/android/pylib/junit/junit_test_instance.py » ('j') | chrome/android/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/lint/suppressions.xml
diff --git a/build/android/lint/suppressions.xml b/build/android/lint/suppressions.xml
index 33882a2d2613da7eb92846a974044f08ec233c51..226c9f95cbda7eef0f4b5960b92b85c4a1b347ab 100644
--- a/build/android/lint/suppressions.xml
+++ b/build/android/lint/suppressions.xml
@@ -227,8 +227,8 @@ Still reading?
<ignore regexp="chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkValidator.java"/>
</issue>
<issue id="PluralsCandidate" severity="Error">
- <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-en-rGB/android_chrome_strings.xml"/>
- <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values/android_chrome_strings.xml"/>
+ <ignore regexp="gen/chrome/android/chrome_strings_grd_grit_output/values-en-rGB/android_chrome_strings.xml"/>
+ <ignore regexp="gen/chrome/android/chrome_strings_grd_grit_output/values/android_chrome_strings.xml"/>
</issue>
<issue id="Recycle" severity="ignore"/>
<issue id="Registered" severity="ignore"/>
@@ -244,17 +244,17 @@ Still reading?
<ignore regexp="chromecast/internal"/>
</issue>
<issue id="StringFormatCount" severity="Error">
- <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-cs/android_chrome_strings.xml"/>
- <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-pl/android_chrome_strings.xml"/>
- <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values/android_chrome_strings.xml"/>
+ <ignore regexp="gen/chrome/android/chrome_strings_grd_grit_output/values-cs/android_chrome_strings.xml"/>
+ <ignore regexp="gen/chrome/android/chrome_strings_grd_grit_output/values-pl/android_chrome_strings.xml"/>
+ <ignore regexp="gen/chrome/android/chrome_strings_grd_grit_output/values/android_chrome_strings.xml"/>
</issue>
<issue id="StringFormatInvalid" severity="Error">
- <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-cs/android_chrome_strings.xml"/>
- <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-da/android_chrome_strings.xml"/>
- <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-pl/android_chrome_strings.xml"/>
- <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-pt-rBR/android_chrome_strings.xml"/>
- <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-sv/android_chrome_strings.xml"/>
- <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-tl/android_chrome_strings.xml"/>
+ <ignore regexp="gen/chrome/android/chrome_strings_grd_grit_output/values-cs/android_chrome_strings.xml"/>
+ <ignore regexp="gen/chrome/android/chrome_strings_grd_grit_output/values-da/android_chrome_strings.xml"/>
+ <ignore regexp="gen/chrome/android/chrome_strings_grd_grit_output/values-pl/android_chrome_strings.xml"/>
+ <ignore regexp="gen/chrome/android/chrome_strings_grd_grit_output/values-pt-rBR/android_chrome_strings.xml"/>
+ <ignore regexp="gen/chrome/android/chrome_strings_grd_grit_output/values-sv/android_chrome_strings.xml"/>
+ <ignore regexp="gen/chrome/android/chrome_strings_grd_grit_output/values-tl/android_chrome_strings.xml"/>
</issue>
<issue id="TextFields" severity="Error">
<ignore regexp="chromecast/internal"/>
@@ -267,16 +267,16 @@ Still reading?
<issue id="UnusedAttribute" severity="ignore"/>
<issue id="UnusedIds" severity="ignore"/>
<issue id="UnusedQuantity" severity="Error">
- <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-cs/android_chrome_strings.xml"/>
- <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-in/android_chrome_strings.xml"/>
- <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-ja/android_chrome_strings.xml"/>
- <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-ko/android_chrome_strings.xml"/>
- <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-lt/android_chrome_strings.xml"/>
- <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-sk/android_chrome_strings.xml"/>
- <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-th/android_chrome_strings.xml"/>
- <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-vi/android_chrome_strings.xml"/>
- <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-zh-rCN/android_chrome_strings.xml"/>
- <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-zh-rTW/android_chrome_strings.xml"/>
+ <ignore regexp="gen/chrome/android/chrome_strings_grd_grit_output/values-cs/android_chrome_strings.xml"/>
+ <ignore regexp="gen/chrome/android/chrome_strings_grd_grit_output/values-in/android_chrome_strings.xml"/>
+ <ignore regexp="gen/chrome/android/chrome_strings_grd_grit_output/values-ja/android_chrome_strings.xml"/>
+ <ignore regexp="gen/chrome/android/chrome_strings_grd_grit_output/values-ko/android_chrome_strings.xml"/>
+ <ignore regexp="gen/chrome/android/chrome_strings_grd_grit_output/values-lt/android_chrome_strings.xml"/>
+ <ignore regexp="gen/chrome/android/chrome_strings_grd_grit_output/values-sk/android_chrome_strings.xml"/>
+ <ignore regexp="gen/chrome/android/chrome_strings_grd_grit_output/values-th/android_chrome_strings.xml"/>
+ <ignore regexp="gen/chrome/android/chrome_strings_grd_grit_output/values-vi/android_chrome_strings.xml"/>
+ <ignore regexp="gen/chrome/android/chrome_strings_grd_grit_output/values-zh-rCN/android_chrome_strings.xml"/>
+ <ignore regexp="gen/chrome/android/chrome_strings_grd_grit_output/values-zh-rTW/android_chrome_strings.xml"/>
</issue>
<!-- TODO(crbug.com/635567): Fix this properly. -->
<issue id="UnusedResources" severity="ignore"/>
« no previous file with comments | « build/android/gyp/create_test_runner_script.py ('k') | build/android/pylib/junit/junit_test_instance.py » ('j') | chrome/android/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698