Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: build/android/lint/suppressions.xml

Issue 2767613002: Expose resources in Robolectric/JUnit tests. (Closed)
Patch Set: Simplify changes to write_build_confg Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« build/android/gyp/write_build_config.py ('K') | « build/android/gyp/write_build_config.py ('k') | build/android/pylib/junit/junit_test_instance.py » ('j') | build/config/android/rules.gni » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <lint> 2 <lint>
3 <!-- 3 <!--
4 STOP! It looks like you want to suppress some lint errors: 4 STOP! It looks like you want to suppress some lint errors:
5 - Have you tried identifing the offending patch? 5 - Have you tried identifing the offending patch?
6 Ask the author for a fix and/or revert the patch. 6 Ask the author for a fix and/or revert the patch.
7 - It is preferred to add suppressions in the code instead of 7 - It is preferred to add suppressions in the code instead of
8 sweeping it under the rug here. See: 8 sweeping it under the rug here. See:
9 9
10 http://developer.android.com/tools/debugging/improving-w-lint.html 10 http://developer.android.com/tools/debugging/improving-w-lint.html
(...skipping 209 matching lines...) Expand 10 before | Expand all | Expand 10 after
220 <ignore regexp="com/android/webview/chromium/ServiceWorkerSettingsAdapter.cl ass"/> 220 <ignore regexp="com/android/webview/chromium/ServiceWorkerSettingsAdapter.cl ass"/>
221 <!-- TODO(crbug.com/635567): Fix this properly. --> 221 <!-- TODO(crbug.com/635567): Fix this properly. -->
222 <ignore regexp="org/chromium/chrome/browser/ChromeActivity.class"/> 222 <ignore regexp="org/chromium/chrome/browser/ChromeActivity.class"/>
223 <!-- TODO(crbug.com/635567): Fix this properly. --> 223 <!-- TODO(crbug.com/635567): Fix this properly. -->
224 <ignore regexp="org/chromium/chrome/browser/ChromeTabbedActivity.class"/> 224 <ignore regexp="org/chromium/chrome/browser/ChromeTabbedActivity.class"/>
225 </issue> 225 </issue>
226 <issue id="PackageManagerGetSignatures"> 226 <issue id="PackageManagerGetSignatures">
227 <ignore regexp="chrome/android/webapk/libs/client/src/org/chromium/webapk/li b/client/WebApkValidator.java"/> 227 <ignore regexp="chrome/android/webapk/libs/client/src/org/chromium/webapk/li b/client/WebApkValidator.java"/>
228 </issue> 228 </issue>
229 <issue id="PluralsCandidate" severity="Error"> 229 <issue id="PluralsCandidate" severity="Error">
230 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-e n-rGB/android_chrome_strings.xml"/> 230 <ignore regexp="gen/chrome/android/chrome_strings_grd_grit_output/values-en- rGB/android_chrome_strings.xml"/>
231 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values/a ndroid_chrome_strings.xml"/> 231 <ignore regexp="gen/chrome/android/chrome_strings_grd_grit_output/values/and roid_chrome_strings.xml"/>
232 </issue> 232 </issue>
233 <issue id="Recycle" severity="ignore"/> 233 <issue id="Recycle" severity="ignore"/>
234 <issue id="Registered" severity="ignore"/> 234 <issue id="Registered" severity="ignore"/>
235 <issue id="RtlCompat" severity="ignore"/> 235 <issue id="RtlCompat" severity="ignore"/>
236 <issue id="RtlEnabled" severity="ignore"/> 236 <issue id="RtlEnabled" severity="ignore"/>
237 <issue id="RtlSymmetry" severity="ignore"/> 237 <issue id="RtlSymmetry" severity="ignore"/>
238 <issue id="SdCardPath"> 238 <issue id="SdCardPath">
239 <ignore regexp="content/public/android/java/src/org/chromium/content/browser /MediaResourceGetter.java"/> 239 <ignore regexp="content/public/android/java/src/org/chromium/content/browser /MediaResourceGetter.java"/>
240 </issue> 240 </issue>
241 <issue id="SetJavaScriptEnabled" severity="ignore"/> 241 <issue id="SetJavaScriptEnabled" severity="ignore"/>
242 <issue id="SignatureOrSystemPermissions" severity="ignore"/> 242 <issue id="SignatureOrSystemPermissions" severity="ignore"/>
243 <issue id="SpUsage" severity="Error"> 243 <issue id="SpUsage" severity="Error">
244 <ignore regexp="chromecast/internal"/> 244 <ignore regexp="chromecast/internal"/>
245 </issue> 245 </issue>
246 <issue id="StringFormatCount" severity="Error"> 246 <issue id="StringFormatCount" severity="Error">
247 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-c s/android_chrome_strings.xml"/> 247 <ignore regexp="gen/chrome/android/chrome_strings_grd_grit_output/values-cs/ android_chrome_strings.xml"/>
248 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-p l/android_chrome_strings.xml"/> 248 <ignore regexp="gen/chrome/android/chrome_strings_grd_grit_output/values-pl/ android_chrome_strings.xml"/>
249 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values/a ndroid_chrome_strings.xml"/> 249 <ignore regexp="gen/chrome/android/chrome_strings_grd_grit_output/values/and roid_chrome_strings.xml"/>
250 </issue> 250 </issue>
251 <issue id="StringFormatInvalid" severity="Error"> 251 <issue id="StringFormatInvalid" severity="Error">
252 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-c s/android_chrome_strings.xml"/> 252 <ignore regexp="gen/chrome/android/chrome_strings_grd_grit_output/values-cs/ android_chrome_strings.xml"/>
253 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-d a/android_chrome_strings.xml"/> 253 <ignore regexp="gen/chrome/android/chrome_strings_grd_grit_output/values-da/ android_chrome_strings.xml"/>
254 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-p l/android_chrome_strings.xml"/> 254 <ignore regexp="gen/chrome/android/chrome_strings_grd_grit_output/values-pl/ android_chrome_strings.xml"/>
255 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-p t-rBR/android_chrome_strings.xml"/> 255 <ignore regexp="gen/chrome/android/chrome_strings_grd_grit_output/values-pt- rBR/android_chrome_strings.xml"/>
256 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-s v/android_chrome_strings.xml"/> 256 <ignore regexp="gen/chrome/android/chrome_strings_grd_grit_output/values-sv/ android_chrome_strings.xml"/>
257 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-t l/android_chrome_strings.xml"/> 257 <ignore regexp="gen/chrome/android/chrome_strings_grd_grit_output/values-tl/ android_chrome_strings.xml"/>
258 </issue> 258 </issue>
259 <issue id="TextFields" severity="Error"> 259 <issue id="TextFields" severity="Error">
260 <ignore regexp="chromecast/internal"/> 260 <ignore regexp="chromecast/internal"/>
261 </issue> 261 </issue>
262 <issue id="TypographyDashes" severity="Error"> 262 <issue id="TypographyDashes" severity="Error">
263 <ignore regexp="chrome/app/policy/android/values-v21/restriction_values.xml" /> 263 <ignore regexp="chrome/app/policy/android/values-v21/restriction_values.xml" />
264 </issue> 264 </issue>
265 <!-- Typos check disabled due to lint bug: http://crbug.com/671170 --> 265 <!-- Typos check disabled due to lint bug: http://crbug.com/671170 -->
266 <issue id="Typos" severity="ignore" /> 266 <issue id="Typos" severity="ignore" />
267 <issue id="UnusedAttribute" severity="ignore"/> 267 <issue id="UnusedAttribute" severity="ignore"/>
268 <issue id="UnusedIds" severity="ignore"/> 268 <issue id="UnusedIds" severity="ignore"/>
269 <issue id="UnusedQuantity" severity="Error"> 269 <issue id="UnusedQuantity" severity="Error">
270 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-c s/android_chrome_strings.xml"/> 270 <ignore regexp="gen/chrome/android/chrome_strings_grd_grit_output/values-cs/ android_chrome_strings.xml"/>
271 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-i n/android_chrome_strings.xml"/> 271 <ignore regexp="gen/chrome/android/chrome_strings_grd_grit_output/values-in/ android_chrome_strings.xml"/>
272 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-j a/android_chrome_strings.xml"/> 272 <ignore regexp="gen/chrome/android/chrome_strings_grd_grit_output/values-ja/ android_chrome_strings.xml"/>
273 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-k o/android_chrome_strings.xml"/> 273 <ignore regexp="gen/chrome/android/chrome_strings_grd_grit_output/values-ko/ android_chrome_strings.xml"/>
274 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-l t/android_chrome_strings.xml"/> 274 <ignore regexp="gen/chrome/android/chrome_strings_grd_grit_output/values-lt/ android_chrome_strings.xml"/>
275 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-s k/android_chrome_strings.xml"/> 275 <ignore regexp="gen/chrome/android/chrome_strings_grd_grit_output/values-sk/ android_chrome_strings.xml"/>
276 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-t h/android_chrome_strings.xml"/> 276 <ignore regexp="gen/chrome/android/chrome_strings_grd_grit_output/values-th/ android_chrome_strings.xml"/>
277 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-v i/android_chrome_strings.xml"/> 277 <ignore regexp="gen/chrome/android/chrome_strings_grd_grit_output/values-vi/ android_chrome_strings.xml"/>
278 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-z h-rCN/android_chrome_strings.xml"/> 278 <ignore regexp="gen/chrome/android/chrome_strings_grd_grit_output/values-zh- rCN/android_chrome_strings.xml"/>
279 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-z h-rTW/android_chrome_strings.xml"/> 279 <ignore regexp="gen/chrome/android/chrome_strings_grd_grit_output/values-zh- rTW/android_chrome_strings.xml"/>
280 </issue> 280 </issue>
281 <!-- TODO(crbug.com/635567): Fix this properly. --> 281 <!-- TODO(crbug.com/635567): Fix this properly. -->
282 <issue id="UnusedResources" severity="ignore"/> 282 <issue id="UnusedResources" severity="ignore"/>
283 <issue id="UnusedResources"> 283 <issue id="UnusedResources">
284 <ignore regexp="PRODUCT_DIR/gen/remoting/android/remoting_android_raw_resour ces/res/raw/credits.html"/> 284 <ignore regexp="PRODUCT_DIR/gen/remoting/android/remoting_android_raw_resour ces/res/raw/credits.html"/>
285 <ignore regexp="PRODUCT_DIR/gen/remoting/android/remoting_android_raw_resour ces/res/raw/credits_css.css"/> 285 <ignore regexp="PRODUCT_DIR/gen/remoting/android/remoting_android_raw_resour ces/res/raw/credits_css.css"/>
286 <ignore regexp="PRODUCT_DIR/gen/remoting/android/remoting_android_raw_resour ces/res/raw/credits_js.js"/> 286 <ignore regexp="PRODUCT_DIR/gen/remoting/android/remoting_android_raw_resour ces/res/raw/credits_js.js"/>
287 <ignore regexp="PRODUCT_DIR/gen/remoting/android/remoting_android_raw_resour ces/res/raw/main.css"/> 287 <ignore regexp="PRODUCT_DIR/gen/remoting/android/remoting_android_raw_resour ces/res/raw/main.css"/>
288 <ignore regexp="android_ui_strings.xml"/> 288 <ignore regexp="android_ui_strings.xml"/>
289 <ignore regexp="android_webview/java/res/drawable-hdpi/ic_play_circle_outlin e_black_48dp.png"/> 289 <ignore regexp="android_webview/java/res/drawable-hdpi/ic_play_circle_outlin e_black_48dp.png"/>
(...skipping 159 matching lines...) Expand 10 before | Expand all | Expand 10 after
449 </issue> 449 </issue>
450 <issue id="ViewConstructor" severity="ignore"/> 450 <issue id="ViewConstructor" severity="ignore"/>
451 <issue id="WrongCall" severity="ignore"/> 451 <issue id="WrongCall" severity="ignore"/>
452 <issue id="WrongConstant"> 452 <issue id="WrongConstant">
453 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/SSLClien tCertificateRequest.java"/> 453 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/SSLClien tCertificateRequest.java"/>
454 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/payments /ui/EditorView.java"/> 454 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/payments /ui/EditorView.java"/>
455 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/signin/S igninAndSyncView.java"/> 455 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/signin/S igninAndSyncView.java"/>
456 <ignore regexp="content/public/android/java/src/org/chromium/content/browser /ChildProcessConnectionImpl.java"/> 456 <ignore regexp="content/public/android/java/src/org/chromium/content/browser /ChildProcessConnectionImpl.java"/>
457 </issue> 457 </issue>
458 </lint> 458 </lint>
OLDNEW
« build/android/gyp/write_build_config.py ('K') | « build/android/gyp/write_build_config.py ('k') | build/android/pylib/junit/junit_test_instance.py » ('j') | build/config/android/rules.gni » ('J')

Powered by Google App Engine
This is Rietveld 408576698